chrome/browser/ui/browser_navigator_browsertest.cc - Issue 23789005: (Try 2) Update chrome://newtab checks in browser tests to use chrome::IsNTPURL().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_navigator_browsertest.cc

Issue 23789005: (Try 2) Update chrome://newtab checks in browser tests to use chrome::IsNTPURL(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revert startup_browser_creator_browsertest changes Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser_navigator_browsertest.cc

diff --git a/chrome/browser/ui/browser_navigator_browsertest.cc b/chrome/browser/ui/browser_navigator_browsertest.cc

index 28424fd68d386046c76037beeb4fe74f00b68123..20fac5d187a173995aefa6ade1d5f11fa662770a 100644

--- a/chrome/browser/ui/browser_navigator_browsertest.cc

+++ b/chrome/browser/ui/browser_navigator_browsertest.cc

@@ -10,6 +10,7 @@

#include "chrome/app/chrome_command_ids.h"

#include "chrome/browser/prefs/incognito_mode_prefs.h"

#include "chrome/browser/profiles/profile.h"

+#include "chrome/browser/search/search.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_commands.h"

#include "chrome/browser/ui/browser_finder.h"

@@ -1092,8 +1093,9 @@ IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest,

p.url = GURL(chrome::kChromeUINewTabURL);

ui_test_utils::NavigateToURL(&p);

EXPECT_EQ(1, browser()->tab_strip_model()->count());

- EXPECT_EQ(GURL(chrome::kChromeUINewTabURL),

- browser()->tab_strip_model()->GetActiveWebContents()->GetURL());

+ EXPECT_TRUE(chrome::IsNTPURL(

+ browser()->tab_strip_model()->GetActiveWebContents()->GetURL(),

+ browser()->profile()));

{

content::WindowedNotificationObserver observer(

« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | chrome/browser/ui/views/constrained_window_views_browsertest.cc » ('j') | no next file with comments »