chrome/browser/sessions/session_restore_browsertest.cc - Issue 23789005: (Try 2) Update chrome://newtab checks in browser tests to use chrome::IsNTPURL().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/session_restore_browsertest.cc

Issue 23789005: (Try 2) Update chrome://newtab checks in browser tests to use chrome::IsNTPURL(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revert startup_browser_creator_browsertest changes Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc ('k') | chrome/browser/ui/browser_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sessions/session_restore_browsertest.cc

diff --git a/chrome/browser/sessions/session_restore_browsertest.cc b/chrome/browser/sessions/session_restore_browsertest.cc

index 9e0490355b1af17795d7e2ee5fe6f58afee9dcf7..22b08355c1b9cc3ca3f5c6a73fc65e774c239574 100644

--- a/chrome/browser/sessions/session_restore_browsertest.cc

+++ b/chrome/browser/sessions/session_restore_browsertest.cc

@@ -15,6 +15,7 @@

#include "chrome/browser/first_run/first_run.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/profiles/profile_manager.h"

+#include "chrome/browser/search/search.h"

#include "chrome/browser/sessions/session_restore.h"

#include "chrome/browser/sessions/session_service.h"

#include "chrome/browser/sessions/session_service_factory.h"

@@ -219,8 +220,9 @@ IN_PROC_BROWSER_TEST_F(SessionRestoreTest, NoSessionRestoreNewWindowChromeOS) {

ASSERT_TRUE(new_browser);

EXPECT_EQ(1, new_browser->tab_strip_model()->count());

- EXPECT_EQ(GURL(chrome::kChromeUINewTabURL),

- new_browser->tab_strip_model()->GetWebContentsAt(0)->GetURL());

+ EXPECT_TRUE(chrome::IsNTPURL(

+ new_browser->tab_strip_model()->GetWebContentsAt(0)->GetURL(),

+ new_browser->profile()));

}

// Test that maximized applications get restored maximized.

« no previous file with comments | « chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc ('k') | chrome/browser/ui/browser_browsertest.cc » ('j') | no next file with comments »