chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc - Issue 23789005: (Try 2) Update chrome://newtab checks in browser tests to use chrome::IsNTPURL().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc

Issue 23789005: (Try 2) Update chrome://newtab checks in browser tests to use chrome::IsNTPURL(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revert startup_browser_creator_browsertest changes Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc ('k') | chrome/browser/sessions/session_restore_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc

diff --git a/chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc b/chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc

index 4c2d3d925acd68e257c6380b375ba7c7482e29e7..77520580ed4dde7df026e815a7bcfae3aa3d2293 100644

--- a/chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc

+++ b/chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc

@@ -11,6 +11,7 @@

#include "base/threading/sequenced_worker_pool.h"

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/profiles/profile.h"

+#include "chrome/browser/search/search.h"

#include "chrome/browser/sessions/session_service.h"

#include "chrome/browser/sessions/session_service_factory.h"

#include "chrome/browser/sessions/session_types.h"

@@ -735,9 +736,9 @@ TEST_F(PersistentTabRestoreServiceTest, PruneEntries) {

EXPECT_EQ(max_entries + 1, service_->entries().size());

PruneEntries();

EXPECT_EQ(max_entries, service_->entries().size());

- EXPECT_EQ(GURL(chrome::kChromeUINewTabURL),

+ EXPECT_TRUE(chrome::IsNTPURL(

static_cast<Tab*>(service_->entries().front())->

- navigations[0].virtual_url());

+ navigations[0].virtual_url(), profile()));

// Don't prune NTPs that have multiple navigations.

// (Erase the last NTP first.)

@@ -751,9 +752,9 @@ TEST_F(PersistentTabRestoreServiceTest, PruneEntries) {

EXPECT_EQ(max_entries, service_->entries().size());

PruneEntries();

EXPECT_EQ(max_entries, service_->entries().size());

- EXPECT_EQ(GURL(chrome::kChromeUINewTabURL),

+ EXPECT_TRUE(chrome::IsNTPURL(

static_cast<Tab*>(service_->entries().front())->

- navigations[1].virtual_url());

+ navigations[1].virtual_url(), profile()));

}

// Regression test for crbug.com/106082