Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: android_webview/public/browser/draw_sw.h

Issue 23789003: Switch AwPixelInfo to wrap SkCanvasLayerState (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: put back in workaroudn Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/in_process_view_renderer.cc ('k') | skia/skia_library.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/public/browser/draw_sw.h
diff --git a/android_webview/public/browser/draw_sw.h b/android_webview/public/browser/draw_sw.h
index 463f59cb1f57db12817df662741cae32576cbebf..201679b91e93a6c68b6f8dbfc1deb934542e047c 100644
--- a/android_webview/public/browser/draw_sw.h
+++ b/android_webview/public/browser/draw_sw.h
@@ -12,21 +12,16 @@
#error "Can't mix C and C++ when using jni.h"
#endif
+struct SkCanvasState;
class SkPicture;
-static const int kAwPixelInfoVersion = 2;
-
-// Values of the AwPixelInfo::config field.
-enum AwPixelConfig {
- AwConfig_RGB_565 = 4,
- AwConfig_ARGB_4444 = 5,
- AwConfig_ARGB_8888 = 6,
-};
+static const int kAwPixelInfoVersion = 3;
// Holds the information required to implement the SW draw to system canvas.
struct AwPixelInfo {
int version; // The kAwPixelInfoVersion this struct was built with.
- int config; // |pixel| format: a value from AwPixelConfig.
+ SkCanvasState* state; // The externalize state in skia format.
+ // TODO(joth): Remove the rest in next patch.
djsollen 2013/09/05 12:10:07 is there a benefit to deferring the removal to a l
joth 2013/09/05 16:10:34 yeah... it's mostly so we have a clean compilation
djsollen 2013/09/05 16:23:44 I'm fine if you want to do it in stages, but it ma
joth 2013/09/05 22:03:39 Done.
int width; // In pixels.
int height; // In pixels.
int row_bytes; // Number of bytes from start of one line to next.
« no previous file with comments | « android_webview/browser/in_process_view_renderer.cc ('k') | skia/skia_library.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698