Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 23789003: Switch AwPixelInfo to wrap SkCanvasLayerState (Closed)

Created:
7 years, 3 months ago by joth
Modified:
7 years, 3 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Switch AwPixelInfo to wrap SkCanvasLayerState Using the new skia utility makes the canvas stack export much simpler BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221593

Patch Set 1 #

Patch Set 2 : rebase + SkCanvasStack gyp #

Patch Set 3 : put back in workaroudn #

Total comments: 4

Patch Set 4 : make a hard break on the struct format #

Patch Set 5 : translate() #

Patch Set 6 : clang #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -86 lines) Patch
M android_webview/browser/in_process_view_renderer.cc View 1 2 3 4 2 chunks +36 lines, -69 lines 0 comments Download
M android_webview/public/browser/draw_sw.h View 1 2 3 4 5 1 chunk +3 lines, -17 lines 0 comments Download
M skia/skia_library.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
joth
7 years, 3 months ago (2013-09-05 05:18:37 UTC) #1
djsollen
https://chromiumcodereview.appspot.com/23789003/diff/7001/android_webview/public/browser/draw_sw.h File android_webview/public/browser/draw_sw.h (right): https://chromiumcodereview.appspot.com/23789003/diff/7001/android_webview/public/browser/draw_sw.h#newcode24 android_webview/public/browser/draw_sw.h:24: // TODO(joth): Remove the rest in next patch. is ...
7 years, 3 months ago (2013-09-05 12:10:06 UTC) #2
joth
https://codereview.chromium.org/23789003/diff/7001/android_webview/public/browser/draw_sw.h File android_webview/public/browser/draw_sw.h (right): https://codereview.chromium.org/23789003/diff/7001/android_webview/public/browser/draw_sw.h#newcode24 android_webview/public/browser/draw_sw.h:24: // TODO(joth): Remove the rest in next patch. On ...
7 years, 3 months ago (2013-09-05 16:10:34 UTC) #3
djsollen
lgtm from a technical point of view, but you will want to update this patch ...
7 years, 3 months ago (2013-09-05 16:23:44 UTC) #4
joth
https://codereview.chromium.org/23789003/diff/7001/android_webview/public/browser/draw_sw.h File android_webview/public/browser/draw_sw.h (right): https://codereview.chromium.org/23789003/diff/7001/android_webview/public/browser/draw_sw.h#newcode24 android_webview/public/browser/draw_sw.h:24: // TODO(joth): Remove the rest in next patch. On ...
7 years, 3 months ago (2013-09-05 22:03:39 UTC) #5
joth
7 years, 3 months ago (2013-09-05 23:38:33 UTC) #6
Kristian Monsen
lgtm
7 years, 3 months ago (2013-09-05 23:43:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/23789003/23001
7 years, 3 months ago (2013-09-06 02:06:44 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 06:01:44 UTC) #9
Message was sent while issue was closed.
Change committed as 221593

Powered by Google App Engine
This is Rietveld 408576698