Move & rename build/sanitize-png-files.sh to tools/resources/optimize-png-files.sh

Move & rename build/sanitize-png-files.sh to tools/resources/optimize-png-files.sh

BUG=none
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221030

[msw, 2013-08-29 21:31:20]

https://codereview.chromium.org/23789002/diff/1/tools/resources/optimize-png-...
File tools/resources/optimize-png-files.sh (right):

https://codereview.chromium.org/23789002/diff/1/tools/resources/optimize-png-...
tools/resources/optimize-png-files.sh:323: Couldn't find $program. Please run
setup.exe and install the $package package."
nit q: is this the right way to wrap the string?

[James Cook, 2013-08-29 21:58:20]

lgtm assuming msw's comment is addressed

[oshima, 2013-08-29 23:30:03]

https://codereview.chromium.org/23789002/diff/1/tools/resources/optimize-png-...
File tools/resources/optimize-png-files.sh (right):

https://codereview.chromium.org/23789002/diff/1/tools/resources/optimize-png-...
tools/resources/optimize-png-files.sh:323: Couldn't find $program. Please run
setup.exe and install the $package package."
On 2013/08/29 21:31:20, msw wrote:
> nit q: is this the right way to wrap the string?

or it can be

   echo \
"Couldn't find $program. ...."

Let me know which way you prefer.

[msw, 2013-08-29 23:44:09]

https://codereview.chromium.org/23789002/diff/1/tools/resources/optimize-png-...
File tools/resources/optimize-png-files.sh (right):

https://codereview.chromium.org/23789002/diff/1/tools/resources/optimize-png-...
tools/resources/optimize-png-files.sh:323: Couldn't find $program. Please run
setup.exe and install the $package package."
On 2013/08/29 23:30:03, oshima wrote:
> On 2013/08/29 21:31:20, msw wrote:
> > nit q: is this the right way to wrap the string?
> 
> or it can be
> 
>    echo \
> "Couldn't find $program. ...."
> 
> Let me know which way you prefer.

How about no wrapping by removing "run setup.exe and" (what setup.exe?).
Or no wrapping by removing 'the' and 'package', like:
      echo "Couldn't find $program. Please run setup.exe and install $package."
Otherwise, I guess I like the '\' wrapping like line 435, but it's just a nit...

[oshima, 2013-09-03 17:32:16]

On 2013/08/29 23:44:09, msw wrote:
>
https://codereview.chromium.org/23789002/diff/1/tools/resources/optimize-png-...
> File tools/resources/optimize-png-files.sh (right):
> 
>
https://codereview.chromium.org/23789002/diff/1/tools/resources/optimize-png-...
> tools/resources/optimize-png-files.sh:323: Couldn't find $program. Please run
> setup.exe and install the $package package."
> On 2013/08/29 23:30:03, oshima wrote:
> > On 2013/08/29 21:31:20, msw wrote:
> > > nit q: is this the right way to wrap the string?
> > 
> > or it can be
> > 
> >    echo \
> > "Couldn't find $program. ...."
> > 
> > Let me know which way you prefer.
> 
> How about no wrapping by removing "run setup.exe and" (what setup.exe?).

It's cygwin setup.exe his is for cygwin path. I updated the message.

> Or no wrapping by removing 'the' and 'package', like:
>       echo "Couldn't find $program. Please run setup.exe and install
$package."
> Otherwise, I guess I like the '\' wrapping like line 435, but it's just a
nit...

I uploaded new patch that looks better. PTAL.

[msw, 2013-09-03 20:44:54]

On 2013/09/03 17:32:16, oshima wrote:
> On 2013/08/29 23:44:09, msw wrote:
> >
>
https://codereview.chromium.org/23789002/diff/1/tools/resources/optimize-png-...
> > File tools/resources/optimize-png-files.sh (right):
> > 
> >
>
https://codereview.chromium.org/23789002/diff/1/tools/resources/optimize-png-...
> > tools/resources/optimize-png-files.sh:323: Couldn't find $program. Please
run
> > setup.exe and install the $package package."
> > On 2013/08/29 23:30:03, oshima wrote:
> > > On 2013/08/29 21:31:20, msw wrote:
> > > > nit q: is this the right way to wrap the string?
> > > 
> > > or it can be
> > > 
> > >    echo \
> > > "Couldn't find $program. ...."
> > > 
> > > Let me know which way you prefer.
> > 
> > How about no wrapping by removing "run setup.exe and" (what setup.exe?).
> 
> It's cygwin setup.exe his is for cygwin path. I updated the message.
> 
> > Or no wrapping by removing 'the' and 'package', like:
> >       echo "Couldn't find $program. Please run setup.exe and install
> $package."
> > Otherwise, I guess I like the '\' wrapping like line 435, but it's just a
> nit...
> 
> I uploaded new patch that looks better. PTAL.

Ah, cool; LGTM!

[commit-bot: I haz the power, 2013-09-03 21:24:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/23789002/11001

[commit-bot: I haz the power, 2013-09-03 21:30:34]

Change committed as 221030