Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: chrome/android/java_sources.gni

Issue 2378803003: [Offline Pages] Added OfflinePageEvaluationBridge for testing. (Closed)
Patch Set: Addressed comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java_sources.gni
diff --git a/chrome/android/java_sources.gni b/chrome/android/java_sources.gni
index 8a06f485b8e64ec8da82882971509a5525a71788..f991e6b5fac8fc9968d5b3701db2d794ec0169c2 100644
--- a/chrome/android/java_sources.gni
+++ b/chrome/android/java_sources.gni
@@ -1082,6 +1082,11 @@ chrome_java_sources = [
"java/src/org/chromium/chrome/browser/widget/newtab/NewTabButton.java",
]
+# Only used for testing, should not be shipped to end users.
+if (!is_official_build) {
Pete Williamson 2016/10/11 22:25:18 Does this mean that the code ends up in Chromium b
agrieve 2016/10/12 01:50:50 Chromium builds also set is_official_build. (it's
+ chrome_java_sources += [ "java/src/org/chromium/chrome/browser/offlinepages/evaluation/OfflinePageEvaluationBridge.java" ]
+}
+
chrome_vr_java_sources = [
"java/src/org/chromium/chrome/browser/vr_shell/VrShell.java",
"java/src/org/chromium/chrome/browser/vr_shell/VrWindowAndroid.java",

Powered by Google App Engine
This is Rietveld 408576698