Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: Source/bindings/v8/V8PerContextData.cpp

Issue 23788005: Remove calls to HandleScope default ctor. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: code review (pfeldman) Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/V8LazyEventListener.cpp ('k') | Source/bindings/v8/V8WorkerGlobalScopeEventListener.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8PerContextData.cpp
diff --git a/Source/bindings/v8/V8PerContextData.cpp b/Source/bindings/v8/V8PerContextData.cpp
index 8f043a9e986834903bd43ad30fbe1cc858aff29b..ab0f66205ad442ebf928049ca066239f146556d1 100644
--- a/Source/bindings/v8/V8PerContextData.cpp
+++ b/Source/bindings/v8/V8PerContextData.cpp
@@ -195,7 +195,7 @@ bool V8PerContextDebugData::setContextDebugData(v8::Handle<v8::Context> context,
{
if (!debugData(context)->IsUndefined())
return false;
- v8::HandleScope scope;
+ v8::HandleScope scope(context->GetIsolate());
v8::Handle<v8::Value> debugData = createDebugData(worldName, debugId);
setDebugData(context, debugData);
return true;
@@ -203,7 +203,7 @@ bool V8PerContextDebugData::setContextDebugData(v8::Handle<v8::Context> context,
int V8PerContextDebugData::contextDebugId(v8::Handle<v8::Context> context)
{
- v8::HandleScope scope;
+ v8::HandleScope scope(context->GetIsolate());
v8::Handle<v8::Value> data = debugData(context);
if (!data->IsString())
« no previous file with comments | « Source/bindings/v8/V8LazyEventListener.cpp ('k') | Source/bindings/v8/V8WorkerGlobalScopeEventListener.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698