Source/bindings/v8/ScriptHeapSnapshot.cpp - Issue 23788005: Remove calls to HandleScope default ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptHeapSnapshot.cpp

Issue 23788005: Remove calls to HandleScope default ctor. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: code review (pfeldman) Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScriptHeapSnapshot.cpp

diff --git a/Source/bindings/v8/ScriptHeapSnapshot.cpp b/Source/bindings/v8/ScriptHeapSnapshot.cpp

index dac1c47392b6f299c058157a262dc6ae34f9c3b6..76ea3689fbc34de4c276199c3243339c1e4b642a 100644

--- a/Source/bindings/v8/ScriptHeapSnapshot.cpp

+++ b/Source/bindings/v8/ScriptHeapSnapshot.cpp

@@ -47,7 +47,7 @@ ScriptHeapSnapshot::~ScriptHeapSnapshot()

String ScriptHeapSnapshot::title() const

{

- v8::HandleScope scope;

+ v8::HandleScope scope(v8::Isolate::GetCurrent());

return toWebCoreString(m_snapshot->GetTitle());

}

« no previous file with comments | « Source/bindings/v8/ScriptEventListener.cpp ('k') | Source/bindings/v8/ScriptScope.cpp » ('j') | no next file with comments »