Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: Source/bindings/v8/DOMRequestState.h

Issue 23788005: Remove calls to HandleScope default ctor. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: code review (pfeldman) Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/v8/NPV8Object.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/DOMRequestState.h
diff --git a/Source/bindings/v8/DOMRequestState.h b/Source/bindings/v8/DOMRequestState.h
index c5bf8469f3bd68c9e54a234b9c9162cbd4050975..2bba07225e61c05649b3588bb3005a10f985270f 100644
--- a/Source/bindings/v8/DOMRequestState.h
+++ b/Source/bindings/v8/DOMRequestState.h
@@ -39,6 +39,7 @@ public:
explicit DOMRequestState(ScriptExecutionContext* scriptExecutionContext)
: m_scriptExecutionContext(scriptExecutionContext)
, m_world(DOMWrapperWorld::current())
+ , m_isolate(getIsolateFromScriptExecutionContext(scriptExecutionContext))
{
}
@@ -51,7 +52,8 @@ public:
class Scope {
public:
explicit Scope(DOMRequestState& state)
- : m_contextScope(state.context())
+ : m_handleScope(state.isolate())
+ , m_contextScope(state.context())
{
}
private:
@@ -64,9 +66,15 @@ public:
return toV8Context(m_scriptExecutionContext, m_world.get());
}
+ v8::Isolate* isolate() const
+ {
+ return m_isolate;
+ }
+
private:
ScriptExecutionContext* m_scriptExecutionContext;
RefPtr<DOMWrapperWorld> m_world;
+ v8::Isolate* m_isolate;
};
}
« no previous file with comments | « no previous file | Source/bindings/v8/NPV8Object.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698