Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: Source/bindings/v8/ScriptScope.cpp

Issue 23788005: Remove calls to HandleScope default ctor. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: code review (pfeldman) Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/v8/ScriptHeapSnapshot.cpp ('k') | Source/bindings/v8/ScriptState.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 21 matching lines...) Expand all
32 #include "bindings/v8/ScriptScope.h" 32 #include "bindings/v8/ScriptScope.h"
33 33
34 #include "bindings/v8/ScriptState.h" 34 #include "bindings/v8/ScriptState.h"
35 #include "wtf/Assertions.h" 35 #include "wtf/Assertions.h"
36 36
37 #include <v8.h> 37 #include <v8.h>
38 38
39 namespace WebCore { 39 namespace WebCore {
40 40
41 ScriptScope::ScriptScope(ScriptState* scriptState, bool reportExceptions) 41 ScriptScope::ScriptScope(ScriptState* scriptState, bool reportExceptions)
42 : m_context(scriptState->context()) 42 : m_handleScope(scriptState->isolate())
43 , m_context(scriptState->context())
43 , m_scope(m_context) 44 , m_scope(m_context)
44 { 45 {
45 m_exceptionCatcher.SetVerbose(reportExceptions); 46 m_exceptionCatcher.SetVerbose(reportExceptions);
46 ASSERT(!m_context.IsEmpty()); 47 ASSERT(!m_context.IsEmpty());
47 } 48 }
48 49
49 bool ScriptScope::success() 50 bool ScriptScope::success()
50 { 51 {
51 if (!m_exceptionCatcher.HasCaught()) 52 if (!m_exceptionCatcher.HasCaught())
52 return true; 53 return true;
53 m_exceptionCatcher.Reset(); 54 m_exceptionCatcher.Reset();
54 return false; 55 return false;
55 } 56 }
56 57
57 } // namespace WebCore 58 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/ScriptHeapSnapshot.cpp ('k') | Source/bindings/v8/ScriptState.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698