Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 23787002: Rename MediaPlayerHostMsg_{DemuxerReady,ReadFromDemuxerAck}_Params to Media{Configs,Data}. (Closed)

Created:
7 years, 3 months ago by scherkus (not reviewing)
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org, ycheo (away), qinmin, dwkang1, wonsik
Visibility:
Public.

Description

Rename MediaPlayerHostMsg_{DemuxerReady,ReadFromDemuxerAck}_Params to Demuxer{Configs,Data}. Life is short and we've only got so much horizontal whitespace to work with. This also helps pave the way for introducing Android demuxer client interfaces for media/ code. BUG=263652 TBR=palmer Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220478

Patch Set 1 #

Total comments: 2

Patch Set 2 : media -> demuxer #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -224 lines) Patch
M content/browser/android/browser_media_player_manager.h View 1 1 chunk +4 lines, -6 lines 0 comments Download
M content/browser/android/browser_media_player_manager.cc View 1 2 chunks +5 lines, -6 lines 0 comments Download
M content/common/media/media_player_messages_android.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/android/media_source_delegate.h View 1 4 chunks +17 lines, -23 lines 0 comments Download
M content/renderer/media/android/media_source_delegate.cc View 1 2 9 chunks +49 lines, -54 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_proxy_android.h View 1 1 chunk +2 lines, -5 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_proxy_android.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M media/base/android/demuxer_stream_player_params.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M media/base/android/demuxer_stream_player_params.cc View 1 2 chunks +4 lines, -9 lines 0 comments Download
M media/base/android/media_decoder_job.h View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M media/base/android/media_decoder_job.cc View 1 2 5 chunks +5 lines, -6 lines 0 comments Download
M media/base/android/media_player_android.h View 1 1 chunk +3 lines, -4 lines 0 comments Download
M media/base/android/media_player_android.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M media/base/android/media_source_player.h View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M media/base/android/media_source_player.cc View 1 2 3 chunks +17 lines, -19 lines 0 comments Download
M media/base/android/media_source_player_unittest.cc View 1 2 4 chunks +65 lines, -67 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
scherkus (not reviewing)
acolwell: I feel you've been sending me too many CLs. This one is for you. ...
7 years, 3 months ago (2013-08-29 21:13:55 UTC) #1
acolwell GONE FROM CHROMIUM
https://codereview.chromium.org/23787002/diff/1/media/base/android/demuxer_stream_player_params.h File media/base/android/demuxer_stream_player_params.h (right): https://codereview.chromium.org/23787002/diff/1/media/base/android/demuxer_stream_player_params.h#newcode20 media/base/android/demuxer_stream_player_params.h:20: struct MEDIA_EXPORT MediaConfigs { nit: How about DemuxerConfigs or ...
7 years, 3 months ago (2013-08-29 22:19:52 UTC) #2
scherkus (not reviewing)
PTAL
7 years, 3 months ago (2013-08-29 22:53:41 UTC) #3
acolwell GONE FROM CHROMIUM
lgtm
7 years, 3 months ago (2013-08-29 22:57:35 UTC) #4
qinmin
lgtm
7 years, 3 months ago (2013-08-29 23:00:04 UTC) #5
ycheo (away)
lgtm
7 years, 3 months ago (2013-08-29 23:13:33 UTC) #6
scherkus (not reviewing)
TBR=palmer for IPC changes (it's reflecting an API rename in media/ code)
7 years, 3 months ago (2013-08-29 23:26:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/23787002/8001
7 years, 3 months ago (2013-08-29 23:28:18 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 02:14:03 UTC) #9
Message was sent while issue was closed.
Change committed as 220478

Powered by Google App Engine
This is Rietveld 408576698