Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: content/public/browser/notification_types.h

Issue 23784005: Provide observer functions for NOTIFICATION_WEB_CONTENTS_CONNECTED, NOTIFICATION_WEB_CONTENTS_SWAPP… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: better name Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/browser/web_contents_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/notification_types.h
diff --git a/content/public/browser/notification_types.h b/content/public/browser/notification_types.h
index db8654c3e9eba7067789911c5105eb2b87bae2d3..acfbf5ed12227edce75c34360f49a7a5f93b71ed 100644
--- a/content/public/browser/notification_types.h
+++ b/content/public/browser/notification_types.h
@@ -109,6 +109,7 @@ enum NotificationType {
// the WebContents. A WEB_CONTENTS_DISCONNECTED notification is
// guaranteed before the source pointer becomes junk. No details are
// expected.
+ // DEPRECATED: Use WebContentsObserver::RenderViewReady()
NOTIFICATION_WEB_CONTENTS_CONNECTED,
// This notification is sent when a WebContents swaps its render view host
@@ -117,11 +118,16 @@ enum NotificationType {
// NOTIFICATION_WEB_CONTENTS_DISCONNECTED notification is guaranteed before
// the source pointer becomes junk. Details are the RenderViewHost that
// has been replaced, or NULL if the old RVH was shut down.
+ // DEPRECATED: Use WebContentsObserver::RenderViewHostSwapped()
NOTIFICATION_WEB_CONTENTS_SWAPPED,
// This message is sent after a WebContents is disconnected from the
// renderer process. The source is a Source<WebContents> with a pointer to
// the WebContents (the pointer is usable). No details are expected.
+ // DEPRECATED: This is fired in two situations: when the render process
+ // crashes, in which case use WebContentsObserver::RenderProcessGone, and when
+ // the WebContents is being torn down, in which case use
+ // WebContentsObserver::WebContentsDestroyed()
NOTIFICATION_WEB_CONTENTS_DISCONNECTED,
// This notification is sent after WebContents' title is updated. The source
@@ -138,6 +144,7 @@ enum NotificationType {
// object holding a reference to a WebContents can listen to that
// notification to properly reset the reference. The source is a
// Source<WebContents>.
+ // DEPRECATED: Use WebContentsObserver::WebContentsDestroyed()
NOTIFICATION_WEB_CONTENTS_DESTROYED,
// A RenderViewHost was created for a WebContents. The source is the
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/browser/web_contents_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698