Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: content/browser/frame_host/navigation_entry_impl.cc

Issue 2378393002: Pass the user_gesture context in the IPC message FrameMsg_CommitNavigation to the renderer. (Closed)
Patch Set: Fix compile failures Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_entry_impl.cc
diff --git a/content/browser/frame_host/navigation_entry_impl.cc b/content/browser/frame_host/navigation_entry_impl.cc
index fbf56542c1609eae1051a8926899c51de2ef4d93..b99d76927214b43d7f590d5bffa5e430f9ac7f92 100644
--- a/content/browser/frame_host/navigation_entry_impl.cc
+++ b/content/browser/frame_host/navigation_entry_impl.cc
@@ -680,9 +680,6 @@ CommonNavigationParams NavigationEntryImpl::ConstructCommonNavigationParams(
StartNavigationParams NavigationEntryImpl::ConstructStartNavigationParams()
const {
return StartNavigationParams(extra_headers(),
-#if defined(OS_ANDROID)
- has_user_gesture(),
-#endif
transferred_global_request_id().child_id,
transferred_global_request_id().request_id);
}
@@ -716,13 +713,17 @@ RequestNavigationParams NavigationEntryImpl::ConstructRequestNavigationParams(
current_length_to_send = 0;
}
+ bool user_gesture = false;
+#if defined(OS_ANDROID)
+ user_gesture = has_user_gesture();
nasko 2016/09/30 20:21:47 I wonder why this needs to be only for Android, bu
+#endif
RequestNavigationParams request_params(
GetIsOverridingUserAgent(), redirects, GetCanLoadLocalResources(),
base::Time::Now(), frame_entry.page_state(), GetPageID(), GetUniqueID(),
is_same_document_history_load, is_history_navigation_in_new_child,
has_subtree_history_items, has_committed_real_load, intended_as_new_entry,
pending_offset_to_send, current_offset_to_send, current_length_to_send,
- IsViewSourceMode(), should_clear_history_list());
+ IsViewSourceMode(), should_clear_history_list(), user_gesture);
#if defined(OS_ANDROID)
if (GetDataURLAsString() &&
GetDataURLAsString()->size() <= kMaxLengthOfDataURLString) {
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_request.cc » ('j') | content/browser/frame_host/navigation_request.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698