Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 23783005: RequestQuotaDispatcher should handle unexpected death of QuotaDispatcherHost gracefully (Closed)

Created:
7 years, 3 months ago by kinuko
Modified:
7 years, 3 months ago
Reviewers:
Avi (use Gerrit), aedla
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

RequestQuotaDispatcher should handle unexpected death of QuotaDispatcherHost gracefully BUG=285380 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222026

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -13 lines) Patch
M content/browser/quota_dispatcher_host.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/quota_dispatcher_host.cc View 12 chunks +29 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
kinuko
Hopefully this fixes the issue? PTL
7 years, 3 months ago (2013-09-05 08:13:47 UTC) #1
aedla
On 2013/09/05 08:13:47, kinuko wrote: > Hopefully this fixes the issue? PTL LGTM I checked ...
7 years, 3 months ago (2013-09-05 09:31:08 UTC) #2
kinuko
avi: can you do an owner's review? On 2013/09/05 09:31:08, aedla wrote: > On 2013/09/05 ...
7 years, 3 months ago (2013-09-05 10:08:30 UTC) #3
Avi (use Gerrit)
I have no idea what the lifetime should look like. Is it expected that the ...
7 years, 3 months ago (2013-09-05 15:08:47 UTC) #4
kinuko
On 2013/09/05 15:08:47, Avi wrote: > I have no idea what the lifetime should look ...
7 years, 3 months ago (2013-09-06 02:27:38 UTC) #5
kinuko
On 2013/09/06 02:27:38, kinuko wrote: > On 2013/09/05 15:08:47, Avi wrote: > > I have ...
7 years, 3 months ago (2013-09-09 02:15:58 UTC) #6
Avi (use Gerrit)
On 2013/09/09 02:15:58, kinuko wrote: > On 2013/09/06 02:27:38, kinuko wrote: > > On 2013/09/05 ...
7 years, 3 months ago (2013-09-09 02:49:11 UTC) #7
kinuko
On 2013/09/09 02:49:11, Avi wrote: > On 2013/09/09 02:15:58, kinuko wrote: > > On 2013/09/06 ...
7 years, 3 months ago (2013-09-09 03:09:51 UTC) #8
Avi (use Gerrit)
Gah! LGTM
7 years, 3 months ago (2013-09-09 03:27:34 UTC) #9
kinuko
On 2013/09/09 03:27:34, Avi wrote: > Gah! LGTM ty :)
7 years, 3 months ago (2013-09-09 04:27:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/23783005/1
7 years, 3 months ago (2013-09-09 08:21:42 UTC) #11
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-09 08:29:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/23783005/1
7 years, 3 months ago (2013-09-09 10:09:12 UTC) #13
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 14:45:53 UTC) #14
Message was sent while issue was closed.
Change committed as 222026

Powered by Google App Engine
This is Rietveld 408576698