Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: ios/chrome/browser/reading_list/reading_list_model_impl.h

Issue 2378123002: Load offline page if reading list entry takes more than 1s to load. (Closed)
Patch Set: Experimental change (reviewers: do not review this PS). Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/reading_list/reading_list_model_impl.h
diff --git a/ios/chrome/browser/reading_list/reading_list_model_impl.h b/ios/chrome/browser/reading_list/reading_list_model_impl.h
index d185c5193618190144f0d2e3de6541d1e11aaa52..28debf78ca77312036b7a6f7bf7ff35007c627e6 100644
--- a/ios/chrome/browser/reading_list/reading_list_model_impl.h
+++ b/ios/chrome/browser/reading_list/reading_list_model_impl.h
@@ -25,8 +25,11 @@ class ReadingListModelImpl : public ReadingListModel, public KeyedService {
ReadingListModelImpl();
~ReadingListModelImpl() override;
+
+ // KeyedService implementation.
void Shutdown() override;
+ // ReadingListModel implementation.
bool loaded() const override;
size_t unread_size() const override;
@@ -35,9 +38,9 @@ class ReadingListModelImpl : public ReadingListModel, public KeyedService {
bool HasUnseenEntries() const override;
void ResetUnseenEntries() override;
- // Returns a specific entry.
- const ReadingListEntry& GetUnreadEntryAtIndex(size_t index) const override;
- const ReadingListEntry& GetReadEntryAtIndex(size_t index) const override;
+ const ReadingListEntry* GetUnreadEntryAtIndex(size_t index) const override;
+ const ReadingListEntry* GetReadEntryAtIndex(size_t index) const override;
+ const ReadingListEntry* GetEntryFromURL(const GURL& gurl) const override;
bool CallbackEntryURL(
const GURL& url,

Powered by Google App Engine
This is Rietveld 408576698