components/sessions/core/serialized_navigation_entry.cc - Issue 2378123002: Load offline page if reading list entry takes more than 1s to load.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sessions/core/serialized_navigation_entry.cc

Issue 2378123002: Load offline page if reading list entry takes more than 1s to load. (Closed)

Patch Set: Experimental change (reviewers: do not review this PS). Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sessions/core/serialized_navigation_entry.cc

diff --git a/components/sessions/core/serialized_navigation_entry.cc b/components/sessions/core/serialized_navigation_entry.cc

index 4f4124c598a5e7c50be2ed812a71946ec0aa6b33..7d941c30bd34d4e6efd339968ee558fcb5fd2b63 100644

--- a/components/sessions/core/serialized_navigation_entry.cc

+++ b/components/sessions/core/serialized_navigation_entry.cc

@@ -362,9 +362,9 @@ sync_pb::TabNavigation SerializedNavigationEntry::ToSyncData() const {

// Page transition core.

static_assert(static_cast<int32_t>(ui::PAGE_TRANSITION_LAST_CORE) ==

- static_cast<int32_t>(ui::PAGE_TRANSITION_KEYWORD_GENERATED),

+ static_cast<int32_t>(ui::PAGE_TRANSITION_READING_LIST),

"PAGE_TRANSITION_LAST_CORE must equal "

- "PAGE_TRANSITION_KEYWORD_GENERATED");

+ "PAGE_TRANSITION_READING_LIST");

switch (ui::PageTransitionStripQualifier(transition_type_)) {

case ui::PAGE_TRANSITION_LINK:

sync_data.set_page_transition(