Load offline page if reading list entry takes more than 1s to load.

ios/chrome/browser/reading_list/reading_list_download_service.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ios/chrome/browser/reading_list/reading_list_download_service.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
@@ skipping 44 matching lines @@
 void ReadingListDownloadService::ReadingListModelLoaded(
     const ReadingListModel* model) {
   DCHECK_EQ(reading_list_model_, model);
   DownloadAllEntries();
 }
 
 void ReadingListDownloadService::ReadingListWillRemoveReadEntry(
     const ReadingListModel* model,
     size_t index) {
   DCHECK_EQ(reading_list_model_, model);
-  RemoveDownloadedEntry(model->GetReadEntryAtIndex(index));
+  const ReadingListEntry* entry = model->GetReadEntryAtIndex(index);
+  if (entry)
+    RemoveDownloadedEntry(*entry);
 }
 
 void ReadingListDownloadService::ReadingListWillRemoveUnreadEntry(
     const ReadingListModel* model,
     size_t index) {
   DCHECK_EQ(reading_list_model_, model);
-  RemoveDownloadedEntry(model->GetUnreadEntryAtIndex(index));
+  const ReadingListEntry* entry = model->GetUnreadEntryAtIndex(index);
+  if (entry)
+    RemoveDownloadedEntry(*entry);
 }
 
 void ReadingListDownloadService::ReadingListWillAddUnreadEntry(
     const ReadingListModel* model,
     const ReadingListEntry& entry) {
   DCHECK_EQ(reading_list_model_, model);
   ScheduleDownloadEntry(entry);
 }
 
 void ReadingListDownloadService::ReadingListWillAddReadEntry(
     const ReadingListModel* model,
     const ReadingListEntry& entry) {
   DCHECK_EQ(reading_list_model_, model);
   ScheduleDownloadEntry(entry);
 }
 
 void ReadingListDownloadService::DownloadAllEntries() {
   DCHECK(reading_list_model_->loaded());
   size_t size = reading_list_model_->unread_size();
   for (size_t i = 0; i < size; i++) {
-    const ReadingListEntry& entry =
+    const ReadingListEntry* entry =
         reading_list_model_->GetUnreadEntryAtIndex(i);
-    this->ScheduleDownloadEntry(entry);
+    if (entry)

[sdefresne, 2016/10/04 13:26:46]

Can this be null? It look like it iterate over all entries and remove them.
Should this instead be DCHECK(entry)?

+      this->ScheduleDownloadEntry(*entry);
   }
   size = reading_list_model_->read_size();
   for (size_t i = 0; i < size; i++) {
-    const ReadingListEntry& entry = reading_list_model_->GetReadEntryAtIndex(i);
-    this->ScheduleDownloadEntry(entry);
+    const ReadingListEntry* entry = reading_list_model_->GetReadEntryAtIndex(i);
+    if (entry)

[sdefresne, 2016/10/04 13:26:46]

ditto

+      this->ScheduleDownloadEntry(*entry);
   }
 }
 
 void ReadingListDownloadService::ScheduleDownloadEntry(
     const ReadingListEntry& entry) {
   DCHECK(reading_list_model_->loaded());
   if (entry.DistilledState() == ReadingListEntry::ERROR ||
       entry.DistilledState() == ReadingListEntry::PROCESSED)
     return;
 
@@ skipping 100 matching lines @@
     for (auto& url : url_to_download_cellular_) {
       ScheduleDownloadEntryFromURL(url);
     }
   }
   if (type == net::NetworkChangeNotifier::CONNECTION_WIFI) {
     for (auto& url : url_to_download_wifi_) {
       ScheduleDownloadEntryFromURL(url);
     }
   }
 }