Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 23780002: Actual cancelation of registration when cancel buttons pressed (Closed)

Created:
7 years, 3 months ago by Noam Samuel
Modified:
7 years, 3 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Actual cancelation of registration when cancel buttons pressed Send cancel request to printer when registration is canceled. BUG=245375 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220646

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -8 lines) Patch
M chrome/browser/local_discovery/privet_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.h View 1 2 3 2 chunks +24 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.cc View 1 2 3 4 chunks +60 lines, -8 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_unittest.cc View 1 2 2 chunks +33 lines, -0 lines 0 comments Download
M chrome/browser/resources/local_discovery/local_discovery.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc View 1 4 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Noam Samuel
7 years, 3 months ago (2013-08-29 20:41:42 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/23780002/diff/5001/chrome/browser/local_discovery/privet_http_impl.cc File chrome/browser/local_discovery/privet_http_impl.cc (right): https://codereview.chromium.org/23780002/diff/5001/chrome/browser/local_discovery/privet_http_impl.cc#newcode99 chrome/browser/local_discovery/privet_http_impl.cc:99: new Cancelation(privet_client_, user_); // Owned by the message ...
7 years, 3 months ago (2013-08-29 20:47:31 UTC) #2
Vitaly Buka (NO REVIEWS)
On 2013/08/29 20:47:31, Vitaly Buka wrote: > lgtm > > https://codereview.chromium.org/23780002/diff/5001/chrome/browser/local_discovery/privet_http_impl.cc > File chrome/browser/local_discovery/privet_http_impl.cc (right): ...
7 years, 3 months ago (2013-08-29 20:48:04 UTC) #3
Noam Samuel
https://codereview.chromium.org/23780002/diff/5001/chrome/browser/local_discovery/privet_http_impl.cc File chrome/browser/local_discovery/privet_http_impl.cc (right): https://codereview.chromium.org/23780002/diff/5001/chrome/browser/local_discovery/privet_http_impl.cc#newcode99 chrome/browser/local_discovery/privet_http_impl.cc:99: new Cancelation(privet_client_, user_); // Owned by the message loop. ...
7 years, 3 months ago (2013-08-30 17:44:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/23780002/10001
7 years, 3 months ago (2013-08-30 17:46:13 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 20:41:04 UTC) #6
Message was sent while issue was closed.
Change committed as 220646

Powered by Google App Engine
This is Rietveld 408576698