Initial definition of HeliumSyncManager and SyncRegistration objects.

blimp/net/helium/helium_sync_manager.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BLIMP_NET_HELIUM_HELIUM_SYNC_MANAGER_H_
+#define BLIMP_NET_HELIUM_HELIUM_SYNC_MANAGER_H_
+
+#include <stdint.h>
+#include <memory>
+
+#include "base/macros.h"
+
+namespace blimp {
+
+class HeliumObject;
+class HeliumTransport;
+class Syncable;
+
+using HeliumObjectId = uint32_t;

[scf, 2016/10/06 17:37:49]

I with proto allowed typedefs so we could define this at the proto file
definition

+
+// TODO(kmarshall): Define this type.
+class HeliumTransport {};
+
+class HeliumSyncManager {
+ public:
+  // RAII object for managing the sync control and registration status of a
+  // Syncable. When a Syncable is registered, it should hold onto the resulting
+  // SyncRegistration object.
+  //
+  // When the Syncable is destroyed, it will delete the
+  // SyncRegistration along with it, which will automatically unregister the
+  // object from the SyncManager.

[scf, 2016/10/06 17:37:49]

Who owns the SyncRegistration? Should we add to the TwoPhaseSyncable so that it
can enforce destruction?

[Kevin M, 2016/10/06 18:41:09]

The Object, which is the TwoPhaseSyncable. So yeah, adding a non-virtual
SyncRegistration setter to the TwoPhaseSyncable seems like a good idea.

[Wez, 2016/10/08 00:38:21]

It would be preferable to keep a clean separation between interfaces and
base-classes, though.

It would also be good to avoid "polluting" Syncable primitives with knowledge of
registration, while still allowing them to be synchronized directly.

+  //
+  // If a Syncable wishes to halt synchronization for any reason (e.g. a tab
+  // is hidden on the Client), it may call SyncRegistration::Pause(), which will
+  // tell the SyncManager to exclude or include the Syncable in state sync.
+  class SyncRegistration {
+   public:
+    explicit SyncRegistration(HeliumSyncManager* sync_manager,
+                              HeliumObjectId id);
+    ~SyncRegistration();
+
+    // Tells the HeliumSyncManager to pause or unpause synchronization for the
+    // HeliumObject associated with |this|.
+    void Pause(bool paused);
+
+    HeliumObjectId id() { return id_; }
+
+   private:
+    HeliumObjectId id_;
+    HeliumSyncManager* sync_manager_;
+
+    DISALLOW_COPY_AND_ASSIGN(SyncRegistration);
+  };
+
+  virtual ~HeliumSyncManager() {}
+
+  // Returns a concrete implementation of HeliumSyncManager.
+  static std::unique_ptr<HeliumSyncManager> Create(
+      std::unique_ptr<HeliumTransport> transport);

[Wez, 2016/10/08 00:38:21]

Given that the impl in this CL is a no-op, and that we may well have a
SyncManager shim to run on 0.5, I'd suggest omitting this for now and adding it
once we have an impl to return. :)

+
+  // Registers a new Syncable for synchronization. The Sync layer allocates a
+  // unique identifier to the Object (including guaranteeing no clashes between
+  // Client & Engine).
+  // The identifier may be used by other Objects to refer to |object|. E.g. the
+  // tab-list Object might include the Id for each tab’s Object.
+  virtual std::unique_ptr<SyncRegistration> Register(Syncable* syncable) = 0;
+
+  // Registers a Syncable for synchronization with a pre-existing ID.
+  // This form is used when the remote peer has created a new Syncable, to
+  // register our local equivalent.
+  virtual std::unique_ptr<SyncRegistration> RegisterExisting(
+      HeliumObjectId id,
+      Syncable* syncable) = 0;
+
+ protected:
+  friend class HeliumSyncManager::SyncRegistration;
+
+  // Tells the HeliumSyncManager to pause or unpause synchronization for the
+  // HeliumObject associated with |this|.
+  virtual void Pause(HeliumObjectId id, bool paused) = 0;

[Wez, 2016/10/08 00:38:21]

Let's leave out stuff like this until we get to implementing it :)

+
+  // Indicates that a Syncable is being destroyed, and should no longer be
+  // synchronized.
+  // Because the Syncable is being destroyed, it is assumed that in-flight
+  // messages
+  // about it are now irrelevant, and the Sync layer should tear down underlying
+  // resources, such as the HeliumStream, immediately.
+  virtual void Unregister(HeliumObjectId id) = 0;
+};
+
+}  // namespace blimp
+
+#endif  // BLIMP_NET_HELIUM_HELIUM_SYNC_MANAGER_H_