Modified directory preparing for app engine for dmprof visualizer

Modified directory preparing for app engine for dmprof visualizer.

Create static folder to put javascript and css files.
Recovered index.html and index.js removed in last issue for app engine.

BUG=259206
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223541

[junjianx, 2013-09-05 09:51:39]

I modified the directory structure for app engine, please review it, thanks.

[sullivan, 2013-09-05 14:42:05]

https://codereview.chromium.org/23777005/diff/1/tools/deep_memory_profiler/vi...
File tools/deep_memory_profiler/visualizer/index.html (right):

https://codereview.chromium.org/23777005/diff/1/tools/deep_memory_profiler/vi...
tools/deep_memory_profiler/visualizer/index.html:29: </body>
Sorry I'm a little confused, but didn't you just delete this file in favor of
having it generated by python? Did you bring it back on purpose?

[junjianx, 2013-09-06 01:08:59]

On 2013/09/05 14:42:05, sullivan wrote:
>
https://codereview.chromium.org/23777005/diff/1/tools/deep_memory_profiler/vi...
> File tools/deep_memory_profiler/visualizer/index.html (right):
> 
>
https://codereview.chromium.org/23777005/diff/1/tools/deep_memory_profiler/vi...
> tools/deep_memory_profiler/visualizer/index.html:29: </body>
> Sorry I'm a little confused, but didn't you just delete this file in favor of
> having it generated by python? Did you bring it back on purpose?

Thanks for your review.

Yes, I deleted index.html and index.js in the last issue because they were
generated by python. But that is only for local usage, for example, user can
type "template.py data.json" in terminal, then index.html will be generated
by python and opened in chrome automatically.

On the other hand, we would also prepare a server by app engine for user to
view and share their dmprof graph. From this issue, we would start the work
of the server side, and this issue modified directory structure for app engine.
index.html and index.js are recovered because they will be used by server.

[Dai Mikurube (NOT FULLTIME), 2013-09-06 04:49:23]

We're rethinking the directory structure for App Engine. Wait a moment...

Almost all the JavaScript files are shared with the existing local version.
Junjian will add some GAE Python scripts and static files. The removed
index.html-like thing will show up for GAE in some (maybe different) way.

[junjianx, 2013-09-06 05:57:15]

@Dai,
I wrote the shell file we talked about, please review this issue again, thanks

[junjianx.google, 2013-09-09 04:53:44]

Hello, @sullivan. I'd like to explain the new stage of dmprof visualizer
including the description of this issue.

As our plan, dmprof visualizer should have two usages, at local or on server.

local usage: user should type ‘./template.py path/to/data.json’ in terminal.
The python script will read in local json and generate html file filled in
with the json data .That's why index.html and index.js were deleted in the
last issue. And if possible, the generated html file would be opened in
browser automatically. Everything above are local operations, nothing
related to server.

server usage: The basic visualization work is the same as local usage.
But user can upload and share local dmprof file with others using app engine.
So the directory is merged to the structure of app engine. All of the js files
up to now is moved to the static folder under the project root directory. And
index.html will be used by server, so I recovered index.html and index.js in
this issue. Now, under the root directory, there should be python files related
to app engine, app engine config file and html template files and the static
folder containing all other js files. template.py is also put under the root
directory, but it wont’t be used by app engine.



On Fri, Sep 6, 2013 at 2:57 PM, <junjianx@chromium.org> wrote:
>
> @Dai,
> I wrote the shell file we talked about, please review this issue again,
thanks
>
> https://codereview.chromium.org/23777005/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sullivan, 2013-09-09 14:03:19]

Overall this looks good, but it would be great to use an open-source tool to
update app engine.

https://codereview.chromium.org/23777005/diff/11001/tools/deep_memory_profile...
File tools/deep_memory_profiler/visualizer/app.sh (right):

https://codereview.chromium.org/23777005/diff/11001/tools/deep_memory_profile...
tools/deep_memory_profiler/visualizer/app.sh:12:
/google/data/ro/projects/apphosting/tools/appcfg_over_stubby.par update .
appcfg_over_stubby is a Google-only tool; this path will not be available to
non-Googlers.

Can you switch to using the publicly available appcfg.py? Also, using the name
app.sh might be confusing because there is a Google-only script with the same
name that does slightly different things (see go/appsh).

[junjianx, 2013-09-10 07:39:27]

Fixed the review problem.

https://codereview.chromium.org/23777005/diff/11001/tools/deep_memory_profile...
File tools/deep_memory_profiler/visualizer/app.sh (right):

https://codereview.chromium.org/23777005/diff/11001/tools/deep_memory_profile...
tools/deep_memory_profiler/visualizer/app.sh:12:
/google/data/ro/projects/apphosting/tools/appcfg_over_stubby.par update .
We plan to test this project only for internal engineers currently.
But we will release it to public later.

On 2013/09/09 14:03:19, sullivan wrote:
> appcfg_over_stubby is a Google-only tool; this path will not be available to
> non-Googlers.
> 
> Can you switch to using the publicly available appcfg.py? Also, using the name
> app.sh might be confusing because there is a Google-only script with the same
> name that does slightly different things (see go/appsh).

[junjianx, 2013-09-10 08:31:26]

Modified run.sh to protect internal information

[sullivan, 2013-09-10 13:29:07]

lgtm

[junjianx, 2013-09-11 10:37:44]

On 2013/09/10 13:29:07, sullivan wrote:
> lgtm

Thanks for your review :)

[commit-bot: I haz the power, 2013-09-17 05:12:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/junjianx@chromium.org/23777005/29001

[commit-bot: I haz the power, 2013-09-17 05:13:59]

Change committed as 223541