Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: tools/run-bisect-manual-test.py

Issue 23777002: Adding comment to inform the user to set up the sandbox manually on Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/run-bisect-manual-test.py
diff --git a/tools/run-bisect-manual-test.py b/tools/run-bisect-manual-test.py
index 3b69358cb9145dcbc7937968dc3fa9211fd98e19..0e08546bf54a540b269b8e4f263ced51231ddfc4 100755
--- a/tools/run-bisect-manual-test.py
+++ b/tools/run-bisect-manual-test.py
@@ -8,6 +8,11 @@
An example usage:
tools/run-bisect-manual-test.py -g 201281 -b 201290
+On Linux platform, follow the instructions in this document
+https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment
+to setup the sandbox manually before running the script. Otherwise the script
+fails to launch Chrome and exits with an error.
+
"""
import os
@@ -109,6 +114,13 @@ def main():
parser.print_help()
return 1
+ if sys.platform.startswith('linux'):
+ if not os.environ.get('CHROME_DEVEL_SANDBOX'):
+ print 'SUID sandbox has not been setup.'\
+ ' See https://code.google.com/p/chromium/wiki/'\
+ 'LinuxSUIDSandboxDevelopment for more information.'
+ return 1
+
return _RunBisectionScript(options)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698