Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2377513004: bluetooth:android: Return the advertised name if advertising (Closed)

Created:
4 years, 2 months ago by ortuno
Modified:
4 years, 1 month ago
Reviewers:
CC:
agrieve+watch_chromium.org, chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth:android: Return the advertised name if advertising Uses the name from the advertising packet rather than retrieving the name through GetDeviceName(). We do this because the call to retrieve the name from the device takes several ms. BUG=629456

Patch Set 1 #

Patch Set 2 : Add tests #

Patch Set 3 : Add note to docs #

Patch Set 4 : Rename instances on other platforms #

Patch Set 5 : Fix merging conflicts #

Patch Set 6 : Format' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -43 lines) Patch
M device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothAdapter.java View 2 chunks +4 lines, -3 lines 0 comments Download
M device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java View 1 chunk +4 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_android.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_android.cc View 1 3 chunks +8 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_mac.mm View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_device.h View 1 2 3 4 3 chunks +8 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device.cc View 1 2 3 4 2 chunks +13 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_device_android.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device_unittest.cc View 1 2 3 4 2 chunks +84 lines, -1 line 0 comments Download
M device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java View 1 5 chunks +28 lines, -21 lines 0 comments Download
M device/bluetooth/test/bluetooth_test.h View 1 4 chunks +9 lines, -5 lines 0 comments Download
M device/bluetooth/test/bluetooth_test.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M device/bluetooth/test/bluetooth_test_bluez.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_mac.mm View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_win.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (21 generated)
ortuno
Description was changed from ========== bluetooth: (WIP) Cache device name Cache the advertised name and ...
4 years, 1 month ago (2016-11-07 02:27:25 UTC) #1
ortuno
The CQ bit was checked by ortuno@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-07 02:28:29 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377513004/40001
4 years, 1 month ago (2016-11-07 02:28:42 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-07 02:38:31 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/267361)
4 years, 1 month ago (2016-11-07 02:38:31 UTC) #5
ortuno
The CQ bit was checked by ortuno@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-07 03:17:08 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377513004/60001
4 years, 1 month ago (2016-11-07 03:17:15 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-07 03:19:46 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/300721) mac_chromium_rel_ng on ...
4 years, 1 month ago (2016-11-07 03:19:46 UTC) #9
ortuno
The CQ bit was checked by ortuno@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-07 03:28:24 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377513004/80001
4 years, 1 month ago (2016-11-07 03:28:44 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-07 03:41:48 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/329941)
4 years, 1 month ago (2016-11-07 03:41:48 UTC) #13
ortuno
The CQ bit was checked by ortuno@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-07 03:44:33 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377513004/80001
4 years, 1 month ago (2016-11-07 03:44:42 UTC) #15
ortuno
The CQ bit was checked by ortuno@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-07 03:45:21 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377513004/100001
4 years, 1 month ago (2016-11-07 03:45:38 UTC) #17
ortuno
Description was changed from ========== bluetooth: Return the advertised name if advertising Uses the name ...
4 years, 1 month ago (2016-11-07 04:22:35 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-07 04:57:01 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 1 month ago (2016-11-07 04:57:01 UTC) #20
ortuno
4 years, 1 month ago (2016-11-07 04:57:11 UTC) #21 
Description was changed from

==========
bluetooth:android: Return the advertised name if advertising

Uses the name from the advertising packet rather than retrieving the name
through
GetDeviceName(). We do this because the call to retrieve the name from the
device
takes several seconds.


BUG=629456
==========

to

==========
bluetooth:android: Return the advertised name if advertising

Uses the name from the advertising packet rather than retrieving the name
through
GetDeviceName(). We do this because the call to retrieve the name from the
device
takes several ms.


BUG=629456
==========

Powered by Google App Engine
This is Rietveld 408576698