Issue 23775005: Go back to the old method of doing file drop promises.

Issue 23775005: Go back to the old method of doing file drop promises. (Closed)

Created:
7 years, 3 months ago by Avi (use Gerrit)

Modified:
7 years, 3 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Go back to the old method of doing file drop promises. kPasteboardTypeFilePromiseContent simply does not work, and it's getting to be a pain working around its issues. This reverts r219601 and r207414, and works around the original bug in a new way. BUG=249271, 278515, 282916 TEST=fixes bug 282916, does not regress either bug 278515 or bug 249271 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221615

Patch Set 1 #

Patch Set 2 : better #

Patch Set 3 : more detail in brokenness #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -150 lines)			Patch
M	content/browser/web_contents/web_contents_view_mac.mm	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	content/browser/web_contents/web_drag_source_mac.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	content/browser/web_contents/web_drag_source_mac.mm	View	1 2	8 chunks	+41 lines, -150 lines	0 comments	Download