Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 23774004: Fix account picker centering (Closed)

Created:
7 years, 3 months ago by noms (inactive)
Modified:
7 years, 3 months ago
CC:
chromium-reviews, arv+watch_chromium.org, Evan Stade
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix account picker centering There's a line in screen_container.css that hardcodes a width of 1100px for body:not(.oobe-display) #inner-container (which applies to the account picker). Setting the right class to the outer container fixes this. TBR=estade@chromium.org BUG=257033 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221556

Patch Set 1 #

Patch Set 2 : force a resize after loading pods #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/resources/chromeos/login/user_pod_row.js View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/resources/user_manager/user_manager.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
noms (inactive)
7 years, 3 months ago (2013-09-04 15:36:22 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
7 years, 3 months ago (2013-09-04 15:38:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/23774004/1
7 years, 3 months ago (2013-09-04 16:38:44 UTC) #3
noms (inactive)
Hi Roger, I've made a small change, as setting the correct style only fixed the ...
7 years, 3 months ago (2013-09-05 15:12:41 UTC) #4
Roger Tawa OOO till Jul 10th
still lgtm
7 years, 3 months ago (2013-09-05 18:23:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/23774004/14001
7 years, 3 months ago (2013-09-05 18:25:13 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 01:22:27 UTC) #7
Message was sent while issue was closed.
Change committed as 221556

Powered by Google App Engine
This is Rietveld 408576698