Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23772008: Drop duplicated DCHECK on FakeDriveService (Closed)

Created:
7 years, 3 months ago by tzik
Modified:
7 years, 3 months ago
Reviewers:
hidehiko
CC:
chromium-reviews
Visibility:
Public.

Description

Drop duplicated DCHECK on FakeDriveService NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M chrome/browser/drive/fake_drive_service.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tzik
Abe-san, may I pick a nit?
7 years, 3 months ago (2013-09-06 07:29:41 UTC) #1
hidehiko
lgtm
7 years, 3 months ago (2013-09-06 07:31:52 UTC) #2
tzik
On 2013/09/06 07:31:52, hidehiko wrote: > lgtm Thanks!
7 years, 3 months ago (2013-09-06 07:33:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/23772008/1
7 years, 3 months ago (2013-09-06 07:33:33 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 08:10:53 UTC) #5
Message was sent while issue was closed. 
Change committed as 221639

Powered by Google App Engine
This is Rietveld 408576698