Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23769009: Removes the --enable-new-media-internals flag. (Closed)

Created:
7 years, 3 months ago by Ty Overby
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Removes the --enable-new-media-internals flag. The new media-internals page is now default. Along with moving files around, this CL also reverts the changes made in https://codereview.chromium.org/19722011 which added the flag --enable-new-media-internals. BUG=260005 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222686

Patch Set 1 #

Patch Set 2 : fixes tests #

Patch Set 3 : removed unused files from old-media-internals #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -1669 lines) Patch
M content/browser/media/media_internals_ui.cc View 1 chunk +0 lines, -6 lines 0 comments Download
A + content/browser/resources/media/client_renderer.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D content/browser/resources/media/event_list.js View 1 2 1 chunk +0 lines, -64 lines 0 comments Download
D content/browser/resources/media/item_store.js View 1 2 1 chunk +0 lines, -70 lines 0 comments Download
A + content/browser/resources/media/main.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/resources/media/manager.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/browser/resources/media/media_internals.css View 1 chunk +67 lines, -43 lines 0 comments Download
M content/browser/resources/media/media_internals.html View 1 chunk +51 lines, -23 lines 0 comments Download
M content/browser/resources/media/media_internals.js View 1 chunk +9 lines, -281 lines 0 comments Download
D content/browser/resources/media/media_player.js View 1 2 1 chunk +0 lines, -154 lines 0 comments Download
D content/browser/resources/media/metrics.js View 1 2 1 chunk +0 lines, -116 lines 0 comments Download
D content/browser/resources/media/new/client_renderer.js View 1 chunk +0 lines, -241 lines 0 comments Download
D content/browser/resources/media/new/main.js View 1 chunk +0 lines, -195 lines 0 comments Download
D content/browser/resources/media/new/manager.js View 1 chunk +0 lines, -114 lines 0 comments Download
D content/browser/resources/media/new/media_internals.css View 1 chunk +0 lines, -95 lines 0 comments Download
D content/browser/resources/media/new/media_internals.html View 1 chunk +0 lines, -56 lines 0 comments Download
D content/browser/resources/media/new/media_internals.js View 1 chunk +0 lines, -15 lines 0 comments Download
D content/browser/resources/media/new/player_info.js View 1 chunk +0 lines, -80 lines 0 comments Download
D content/browser/resources/media/new/util.js View 1 chunk +0 lines, -47 lines 0 comments Download
A + content/browser/resources/media/player_info.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/browser/resources/media/util.js View 1 chunk +38 lines, -65 lines 0 comments Download
M content/content_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/test/webui_resource_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Ty Overby
7 years, 3 months ago (2013-09-10 21:42:23 UTC) #1
scherkus (not reviewing)
lgtm!
7 years, 3 months ago (2013-09-11 19:38:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoverby@chromium.org/23769009/6001
7 years, 3 months ago (2013-09-11 19:41:23 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=24973
7 years, 3 months ago (2013-09-11 19:52:32 UTC) #4
Ty Overby
creis@: OWNERS review for the following: content/content_resources.grd content/public/common/content_switches.h content/public/common/content_switches.cc arv@: OWNERS review for the following: ...
7 years, 3 months ago (2013-09-11 19:57:43 UTC) #5
Charlie Reis
On 2013/09/11 19:57:43, Ty Overby wrote: > creis@: OWNERS review for the following: > content/content_resources.grd ...
7 years, 3 months ago (2013-09-11 20:14:48 UTC) #6
Ty Overby
On 2013/09/11 20:14:48, creis wrote: > On 2013/09/11 19:57:43, Ty Overby wrote: > > creis@: ...
7 years, 3 months ago (2013-09-11 20:35:02 UTC) #7
arv (Not doing code reviews)
LGTM
7 years, 3 months ago (2013-09-11 20:50:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoverby@chromium.org/23769009/6001
7 years, 3 months ago (2013-09-11 21:06:56 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-12 00:55:32 UTC) #10
Message was sent while issue was closed. 
Change committed as 222686

Powered by Google App Engine
This is Rietveld 408576698