rietveld.py - Issue 23766025: Enable binary file upload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: rietveld.py

Issue 23766025: Enable binary file upload. (Closed) Base URL: http://src.chromium.org/svn/trunk/tools/depot_tools/

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: rietveld.py

===================================================================

--- rietveld.py (revision 218333)

+++ rietveld.py (working copy)

@@ -149,16 +149,11 @@

filename,

'Binary file is empty. Maybe the file wasn\'t uploaded in the '

'first place?')

- raise patch.UnsupportedPatchFormat(

+ out.append(patch.FilePatchBinary(

filename,

- 'Binary file support is temporarilly disabled due to a bug. '

- 'Please commit blindly the binary files first then commit the '

- 'source change as a separate CL. Sorry for the annoyance.')

- #out.append(patch.FilePatchBinary(

- # filename,

- # content,

- # svn_props,

- # is_new=(status[0] == 'A')))

+ content,

+ svn_props,

+ is_new=(status[0] == 'A')))

continue

try:

« no previous file with comments | « no previous file | no next file » | no next file with comments »