Issue 23766009: Telemetry: smoothness measurement throws MissingTimelineMarker.

Issue 23766009: Telemetry: smoothness measurement throws MissingTimelineMarker. (Closed)

Created:
7 years, 3 months ago by Dominik Grewe

Modified:
7 years, 3 months ago

Reviewers:
bulach, dtu

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Telemetry: smoothness measurement throws MissingTimelineMarker. Rather than throwing a generic LookupError exception when the timeline marker cannot be found in the trace, throw a MissingTimelineMarker which is a subclass of page_measurement.MeasurementFailure. These exceptios get caught by the page runner. Stop catching LookupError exeptions in _RunPage. BUG=238864 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222150

Patch Set 1 #

Total comments: 1

Patch Set 2 : Insert line breaks inbetween top-levels. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	tools/perf/measurements/smoothness.py	View	1	2 chunks	+9 lines, -1 line	0 comments	Download
	M	tools/telemetry/telemetry/page/page_runner.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Dominik Grewe

Reverts https://codereview.chromium.org/23726017/ and makes smoothness throw new exception that is a subclass of page_test.Failure and ...

7 years, 3 months ago (2013-09-05 09:33:30 UTC) #1

bulach

lgtm, thanks for the quick follow up! https://codereview.chromium.org/23766009/diff/1/tools/perf/measurements/smoothness.py File tools/perf/measurements/smoothness.py (right): https://codereview.chromium.org/23766009/diff/1/tools/perf/measurements/smoothness.py#newcode17 tools/perf/measurements/smoothness.py:17: ultra nit: ...

7 years, 3 months ago (2013-09-05 10:30:32 UTC) #2

Dominik Grewe

On 2013/09/05 10:30:32, bulach wrote: > lgtm, thanks for the quick follow up! > > ...

7 years, 3 months ago (2013-09-05 10:39:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominikg@chromium.org/23766009/6001

7 years, 3 months ago (2013-09-09 09:11:17 UTC) #5

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=76733

7 years, 3 months ago (2013-09-09 18:20:14 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominikg@chromium.org/23766009/6001

7 years, 3 months ago (2013-09-09 18:45:55 UTC) #7

Message was sent while issue was closed.

Change committed as 222150

Expand Messages | Collapse Messages