Issue 23766008: Delete IBusEngineServiceImpl which is no longer used for production.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23766008: Delete IBusEngineServiceImpl which is no longer used for production. (Closed)

Created:
7 years, 3 months ago by Hiro Komatsu

Modified:
7 years, 3 months ago

Reviewers:
satorux1, Seigo Nonaka

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

There are two implementations for IBusEngineService, IBusEngineServiceImpl and IBusEngineServiceDaemonlessImpl. This CL deletes IBusEngineServiceImpl which is no longer used. BUG=275262 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221660

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -1665 lines)			Patch
M	chromeos/chromeos.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chromeos/dbus/dbus_thread_manager.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chromeos/dbus/ibus/ibus_constants.h	View	1 chunk	+0 lines, -51 lines	0 comments	Download
M	chromeos/dbus/ibus/ibus_engine_service.h	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	chromeos/dbus/ibus/ibus_engine_service.cc	View	2 chunks	+2 lines, -475 lines	0 comments	Download
D	chromeos/dbus/ibus/ibus_engine_service_unittest.cc	View	1 chunk	+0 lines, -1126 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Hiro Komatsu

There are two implementations for IBusEngineService, IBusEngineServiceImpl and IBusEngineServiceDaemonlessImpl. This CL deletes IBusEngineServiceImpl which is ...

7 years, 3 months ago (2013-09-02 02:14:39 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/23766008/1

7 years, 3 months ago (2013-09-06 06:22:29 UTC) #4

Message was sent while issue was closed.

Change committed as 221660

Expand Messages | Collapse Messages