Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1533)

Issue 23764002: The shared worker repository shouldn't be available on Android. (Closed)

Created:
7 years, 3 months ago by Peter Beverloo
Modified:
7 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

The shared worker repository shouldn't be available on Android. Android does not support Shared Workers right now, but is exposing the window.SharedWorker constructor to web pages. Returning NULL when trying to get the shared worker repository fixes this. BUG=154571 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220425

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Peter Beverloo
7 years, 3 months ago (2013-08-29 15:16:11 UTC) #1
jamesr
lgtm. This seems a little weird, though, that we check the command line directly instead ...
7 years, 3 months ago (2013-08-29 18:44:49 UTC) #2
Peter Beverloo
On 2013/08/29 18:44:49, jamesr wrote: > lgtm. This seems a little weird, though, that we ...
7 years, 3 months ago (2013-08-29 18:50:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/23764002/1
7 years, 3 months ago (2013-08-29 18:53:10 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-08-29 23:23:57 UTC) #5
Message was sent while issue was closed.
Change committed as 220425

Powered by Google App Engine
This is Rietveld 408576698