Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: scripts/slave/recipe_modules/goma/example.expected/mac.json

Issue 2375843005: Stop redirect stdout/stderr and remove close_fds=True (Closed)
Patch Set: add comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/goma/example.expected/mac.json
diff --git a/scripts/slave/recipe_modules/goma/example.expected/mac.json b/scripts/slave/recipe_modules/goma/example.expected/mac.json
index 2afaa58b4087e4722d83b59466b8324eb9b69660..b4f04444f3baa24a38e5d9d9f75df38114678381 100644
--- a/scripts/slave/recipe_modules/goma/example.expected/mac.json
+++ b/scripts/slave/recipe_modules/goma/example.expected/mac.json
@@ -85,13 +85,14 @@
"RECIPE_MODULE[build::goma]/resources/cloudtail_utils.py",
"start",
"--cloudtail-path",
- "[CACHE]/cipd/goma/cloudtail"
+ "[CACHE]/cipd/goma/cloudtail",
+ "--pid-file",
+ "[TMP_BASE]/cloudtail.pid"
],
"env": {
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"
},
- "name": "start cloudtail",
- "stdout": "/path/to/tmp/"
+ "name": "start cloudtail"
},
{
"cmd": [
@@ -201,8 +202,8 @@
"-u",
"RECIPE_MODULE[build::goma]/resources/cloudtail_utils.py",
"stop",
- "--killed-pid",
- "12345"
+ "--killed-pid-file",
+ "[TMP_BASE]/cloudtail.pid"
],
"name": "stop cloudtail"
},

Powered by Google App Engine
This is Rietveld 408576698