Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 23757054: telemetry: Add 'webkit' category back to smoothness benchmark. (Closed)

Created:
7 years, 3 months ago by ernstm
Modified:
7 years, 3 months ago
Reviewers:
tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

telemetry: Add 'webkit' category back to smoothness benchmark. We still need the 'webkit' category in the trace until the reference build is updated to a revision that uses 'webkit.console' for the timeline markers. R=tonyg@chromium.org BUG=282712 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223477

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added comment to remove 'webkit' category later. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/perf/measurements/smoothness.py View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ernstm
Tony, please take a look. This should fix the issue with the reference build.
7 years, 3 months ago (2013-09-16 20:15:17 UTC) #1
tonyg
lgtm https://codereview.chromium.org/23757054/diff/1/tools/perf/measurements/smoothness.py File tools/perf/measurements/smoothness.py (right): https://codereview.chromium.org/23757054/diff/1/tools/perf/measurements/smoothness.py#newcode47 tools/perf/measurements/smoothness.py:47: tab.browser.StartTracing('webkit,webkit.console,benchmark', 60) You might consider a: TODO(ernstm): Remove ...
7 years, 3 months ago (2013-09-16 20:43:47 UTC) #2
ernstm
https://codereview.chromium.org/23757054/diff/1/tools/perf/measurements/smoothness.py File tools/perf/measurements/smoothness.py (right): https://codereview.chromium.org/23757054/diff/1/tools/perf/measurements/smoothness.py#newcode47 tools/perf/measurements/smoothness.py:47: tab.browser.StartTracing('webkit,webkit.console,benchmark', 60) On 2013/09/16 20:43:49, tonyg wrote: > You ...
7 years, 3 months ago (2013-09-16 20:54:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/23757054/6001
7 years, 3 months ago (2013-09-16 20:57:48 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 23:56:55 UTC) #5
Message was sent while issue was closed.
Change committed as 223477

Powered by Google App Engine
This is Rietveld 408576698