Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 23757043: Install png optimization commands for optimization levels >= 1 (Closed)

Created:
7 years, 3 months ago by please use gerrit instead
Modified:
7 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews
Visibility:
Public.

Description

Install png optimization commands for optimization levels >= 1 The script optimize-png-files.sh requires optipng, advdef, and pngout when running at optimization levels 1 and 2, but checks for these tools only at level 2. This CL changes optimize-png-files.sh to also check for the required tools at level 1 optimization. TEST=Uninstall optipng and run the script with -o1 parameter. R=oshima@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223387

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/resources/optimize-png-files.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
please use gerrit instead
Mitsuru: PTAL.
7 years, 3 months ago (2013-09-14 11:16:53 UTC) #1
oshima
lgtm
7 years, 3 months ago (2013-09-16 17:13:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/23757043/1
7 years, 3 months ago (2013-09-16 17:14:30 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 19:57:20 UTC) #4
Message was sent while issue was closed.
Change committed as 223387

Powered by Google App Engine
This is Rietveld 408576698