Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 23757031: Add getFloat/setFloat funcs to SkMatrix44 (Closed)

Created:
7 years, 3 months ago by enne (OOO)
Modified:
7 years, 3 months ago
Reviewers:
Tom Hudson, reed1
CC:
skia-review_googlegroups.com, danakj
Visibility:
Public.

Description

Add getFloat/setFloat funcs to SkMatrix44 These match the existing getDouble/setDouble functions. Committed: http://code.google.com/p/skia/source/detail?r=11355

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M include/utils/SkMatrix44.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
enne (OOO)
7 years, 3 months ago (2013-09-10 21:59:59 UTC) #1
enne (OOO)
This came up as a part of https://codereview.chromium.org/23043011/, and it seemed convenient to add symmetric ...
7 years, 3 months ago (2013-09-10 22:02:09 UTC) #2
tomhudson
It's fine with me, and I've been following 23043011 with interest, but as an external ...
7 years, 3 months ago (2013-09-11 11:19:15 UTC) #3
reed1
lgtm
7 years, 3 months ago (2013-09-11 14:27:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/enne@chromium.org/23757031/1
7 years, 3 months ago (2013-09-11 16:45:56 UTC) #5
commit-bot: I haz the power
Retried try job too often on Build-Ubuntu12-GCC-x86_64-Release-Trybot for step(s) BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests, BuildTools ...
7 years, 3 months ago (2013-09-11 16:50:28 UTC) #6
enne (OOO)
On 2013/09/11 16:50:28, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 3 months ago (2013-09-11 18:28:33 UTC) #7
reed1
On 2013/09/11 18:28:33, enne wrote: > On 2013/09/11 16:50:28, I haz the power (commit-bot) wrote: ...
7 years, 3 months ago (2013-09-11 19:03:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/enne@chromium.org/23757031/1
7 years, 3 months ago (2013-09-13 16:27:30 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-18 18:52:12 UTC) #10
Message was sent while issue was closed.
Change committed as 11355

Powered by Google App Engine
This is Rietveld 408576698