Fix crash for badly formed ONC

Fix crash for badly formed ONC

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221599

[stevenjb, 2013-09-05 18:14:29]

Ran into this while adding a test with "Wifi": {} instead of "WiFi": {} in the
properties dictionary. Should log an ERROR and not crash.

[pneubeck (no reviews), 2013-09-05 19:27:43]

lgtm, however I'd be interested in how a badly formed ONC can end-up in this
function. That should be prevented.

I'd guess that it happened through
ManagedNetworkConfigurationHandlerImpl::CreateConfiguration, which is missing a
call to onc_validator. It should reject/filter invalid settings.

I can setup a CL for that.

[stevenjb, 2013-09-05 19:31:32]

On 2013/09/05 19:27:43, pneubeck wrote:
> lgtm, however I'd be interested in how a badly formed ONC can end-up in this
> function. That should be prevented.
> 
> I'd guess that it happened through
> ManagedNetworkConfigurationHandlerImpl::CreateConfiguration, which is missing
a
> call to onc_validator. It should reject/filter invalid settings.
> 
> I can setup a CL for that.

OK, yeah, that would make sense. Thanks.

[commit-bot: I haz the power, 2013-09-05 19:31:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/23757025/3001

[commit-bot: I haz the power, 2013-09-06 06:12:25]

Change committed as 221599