src/builtins.cc - Issue 23757017: remove Isolate::Current from most files starting with 'o' through 'r'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins.cc

Issue 23757017: remove Isolate::Current from most files starting with 'o' through 'r' (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/builtins.cc

diff --git a/src/builtins.cc b/src/builtins.cc

index fea503b015e51e20fe226a603b3a21d7e44db2de..61b6c9b5b7dff2460a77cff7cc32426e5df85246 100644

--- a/src/builtins.cc

+++ b/src/builtins.cc

@@ -594,7 +594,7 @@ BUILTIN(ArrayPop) {

if (accessor->HasElement(array, array, new_length, elms_obj)) {

maybe_result = accessor->Get(array, array, new_length, elms_obj);

} else {

- maybe_result = array->GetPrototype()->GetElement(len - 1);

+ maybe_result = array->GetPrototype()->GetElement(isolate, len - 1);

}

if (maybe_result->IsFailure()) return maybe_result;

MaybeObject* maybe_failure =

« no previous file with comments | « src/api.cc ('k') | src/execution.cc » ('j') | src/objects.cc » ('J')