Issue 23757011: Remove the unused sampling profiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23757011: Remove the unused sampling profiler. (Closed)

Created:
7 years, 3 months ago by Elliot Glaysher

Modified:
7 years, 3 months ago

Reviewers:
brettw

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove the unused sampling profiler. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220680

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -434 lines)			Patch
M	base/base.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	base/base.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	base/win/sampling_profiler.h	View	1 chunk	+0 lines, -73 lines	0 comments	Download
D	base/win/sampling_profiler.cc	View	1 chunk	+0 lines, -238 lines	0 comments	Download
D	base/win/sampling_profiler_unittest.cc	View	1 chunk	+0 lines, -120 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

brettw

LGTM, although I was not aware of this one, I was thinking of something else!

7 years, 3 months ago (2013-08-29 23:58:11 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/23757011/1

7 years, 3 months ago (2013-08-30 00:09:09 UTC) #3

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=74228

7 years, 3 months ago (2013-08-30 09:03:24 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/23757011/1

7 years, 3 months ago (2013-08-30 17:09:25 UTC) #5

Message was sent while issue was closed.

Change committed as 220680

Expand Messages | Collapse Messages