Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5298)

Unified Diff: chrome/browser/google_apis/drive_api_url_generator.h

Issue 23757004: Refactor InsertResourceRequest and DeleteResourceRequest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/google_apis/drive_api_url_generator.h
diff --git a/chrome/browser/google_apis/drive_api_url_generator.h b/chrome/browser/google_apis/drive_api_url_generator.h
index 1a64a50463b044d68c60f281fae11cbdc34b9a84..5173545b45591b58d58563fbd3571d4e669ec6d3 100644
--- a/chrome/browser/google_apis/drive_api_url_generator.h
+++ b/chrome/browser/google_apis/drive_api_url_generator.h
@@ -63,19 +63,13 @@ class DriveApiUrlGenerator {
const std::string& page_token,
int64 start_change_id) const;
- // Returns a URL to add a resource to a directory with |resource_id|.
- // Note that the |resource_id| is corresponding to the "folder id" in the
- // document: https://developers.google.com/drive/v2/reference/children/insert
- // but we use the term "resource" for consistency in our code.
- GURL GetChildrenUrl(const std::string& resource_id) const;
+ // Returns a URL to add a resource to a directory with |folder_id|.
+ GURL GetChildrenInsertUrl(const std::string& folder_id) const;
// Returns a URL to remove a resource with |child_id| from a directory
// with |folder_id|.
- // Note that we use the name "folder" for the parameter, in order to be
- // consistent with the drive API document:
- // https://developers.google.com/drive/v2/reference/children/delete
- GURL GetChildrenUrlForRemoval(const std::string& folder_id,
- const std::string& child_id) const;
+ GURL GetChildrenDeleteUrl(const std::string& child_id,
+ const std::string& folder_id) const;
// Returns a URL to initiate uploading a new file.
GURL GetInitiateUploadNewFileUrl() const;
« no previous file with comments | « chrome/browser/google_apis/drive_api_requests_unittest.cc ('k') | chrome/browser/google_apis/drive_api_url_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698