Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1335)

Unified Diff: chrome/browser/drive/drive_api_service.cc

Issue 23757004: Refactor InsertResourceRequest and DeleteResourceRequest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/google_apis/drive_api_requests.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/drive/drive_api_service.cc
diff --git a/chrome/browser/drive/drive_api_service.cc b/chrome/browser/drive/drive_api_service.cc
index 9cb3d73345f3f179df4957286130cbe142ee2f66..1eb5be9823be5163d0e6c00d830de6ee208e28b9 100644
--- a/chrome/browser/drive/drive_api_service.cc
+++ b/chrome/browser/drive/drive_api_service.cc
@@ -54,8 +54,9 @@ using google_apis::UploadRangeResponse;
using google_apis::drive::AboutGetRequest;
using google_apis::drive::AppsListRequest;
using google_apis::drive::ChangesListRequest;
+using google_apis::drive::ChildrenDeleteRequest;
+using google_apis::drive::ChildrenInsertRequest;
using google_apis::drive::ContinueGetFileListRequest;
-using google_apis::drive::DeleteResourceRequest;
using google_apis::drive::DownloadFileRequest;
using google_apis::drive::FilesCopyRequest;
using google_apis::drive::FilesGetRequest;
@@ -66,7 +67,6 @@ using google_apis::drive::FilesTrashRequest;
using google_apis::drive::GetUploadStatusRequest;
using google_apis::drive::InitiateUploadExistingFileRequest;
using google_apis::drive::InitiateUploadNewFileRequest;
-using google_apis::drive::InsertResourceRequest;
using google_apis::drive::ResumeUploadRequest;
namespace drive {
@@ -712,13 +712,11 @@ CancelCallback DriveAPIService::AddResourceToDirectory(
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
DCHECK(!callback.is_null());
- return sender_->StartRequestWithRetry(
- new InsertResourceRequest(
- sender_.get(),
- url_generator_,
- parent_resource_id,
- resource_id,
- callback));
+ ChildrenInsertRequest* request =
+ new ChildrenInsertRequest(sender_.get(), url_generator_, callback);
+ request->set_folder_id(parent_resource_id);
+ request->set_id(resource_id);
+ return sender_->StartRequestWithRetry(request);
}
CancelCallback DriveAPIService::RemoveResourceFromDirectory(
@@ -728,13 +726,11 @@ CancelCallback DriveAPIService::RemoveResourceFromDirectory(
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
DCHECK(!callback.is_null());
- return sender_->StartRequestWithRetry(
- new DeleteResourceRequest(
- sender_.get(),
- url_generator_,
- parent_resource_id,
- resource_id,
- callback));
+ ChildrenDeleteRequest* request =
+ new ChildrenDeleteRequest(sender_.get(), url_generator_, callback);
+ request->set_child_id(resource_id);
+ request->set_folder_id(parent_resource_id);
+ return sender_->StartRequestWithRetry(request);
}
CancelCallback DriveAPIService::InitiateUploadNewFile(
« no previous file with comments | « no previous file | chrome/browser/google_apis/drive_api_requests.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698