Issue 23757004: Refactor InsertResourceRequest and DeleteResourceRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23757004: Refactor InsertResourceRequest and DeleteResourceRequest. (Closed)

Created:
7 years, 3 months ago by hidehiko

Modified:
7 years, 3 months ago

Reviewers:
kinaba

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Refactor InsertResourceRequest and DeleteResourceRequest. The operations are mapped to "Children: insert" and "Children: delete" on Drive API v2. To adapt the API more, renames and changes the style. BUG=277253 TEST=Ran unit_tests and tested manually. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220643

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -129 lines)			Patch
M	chrome/browser/drive/drive_api_service.cc	View	1	4 chunks	+12 lines, -16 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_requests.h	View	1	1 chunk	+41 lines, -28 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_requests.cc	View	1	1 chunk	+19 lines, -28 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_requests_unittest.cc	View	1	3 chunks	+18 lines, -20 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_url_generator.h	View	1	1 chunk	+4 lines, -10 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_url_generator.cc	View	1	1 chunk	+6 lines, -7 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_url_generator_unittest.cc	View	1	1 chunk	+18 lines, -20 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23757004/5001

7 years, 3 months ago (2013-08-30 15:37:09 UTC) #3

Message was sent while issue was closed.

Change committed as 220643

Expand Messages | Collapse Messages