[rac] Show amex specific cvc hint

components/autofill/content/browser/wallet/wallet_items.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/browser/wallet/wallet_items.h"
 
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
@@ skipping 62 matching lines @@
     return WalletItems::MaskedInstrument::DISABLED_FOR_THIS_MERCHANT;
   if (status_string == "UNSUPPORTED_COUNTRY")
     return WalletItems::MaskedInstrument::UNSUPPORTED_COUNTRY;
   if (status_string == "EXPIRED")
     return WalletItems::MaskedInstrument::EXPIRED;
   if (status_string == "BILLING_INCOMPLETE")
     return WalletItems::MaskedInstrument::BILLING_INCOMPLETE;
   return WalletItems::MaskedInstrument::INAPPLICABLE;
 }
 
+std::string StringFromType(WalletItems::MaskedInstrument::Type type) {

[Evan Stade, 2013/09/18 01:34:39]

can you call this something slightly different? It seems like it should do the
opposite of TypeFromString, but it doesn't.

[please use gerrit instead, 2013/09/18 15:22:44]

Done. Renamed to StringIdentifierFromType. The comment that describes these
strings in credt_card.h: "The string identifiers for credit card icon
resources." 

+  switch (type) {
+    case WalletItems::MaskedInstrument::VISA:
+      return kVisaCard;
+    case WalletItems::MaskedInstrument::MASTER_CARD:
+      return kMasterCard;
+    case WalletItems::MaskedInstrument::AMEX:
+      return kAmericanExpressCard;
+    case WalletItems::MaskedInstrument::DISCOVER:
+      return kDiscoverCard;
+    default:
+      return kGenericCard;
+  }
+}
+
 }  // anonymous namespace
 
 WalletItems::MaskedInstrument::MaskedInstrument(
     const base::string16& descriptive_name,
     const WalletItems::MaskedInstrument::Type& type,
     const std::vector<base::string16>& supported_currencies,
     const base::string16& last_four_digits,
     int expiration_month,
     int expiration_year,
     scoped_ptr<Address> address,
@@ skipping 227 matching lines @@
 
     case CREDIT_CARD_NUMBER:
       return DisplayName();
 
     case CREDIT_CARD_EXP_4_DIGIT_YEAR:
       return base::IntToString16(expiration_year());
 
     case CREDIT_CARD_VERIFICATION_CODE:
       break;
 
+    case CREDIT_CARD_TYPE:
+      return UTF8ToUTF16(StringFromType(type_));
+
     default:
       NOTREACHED();
   }
 
   return base::string16();
 }
 
 WalletItems::LegalDocument::~LegalDocument() {}
 
 scoped_ptr<WalletItems::LegalDocument>
@@ skipping 176 matching lines @@
          VectorsAreEqual<LegalDocument>(legal_documents(),
                                         other.legal_documents());
 }
 
 bool WalletItems::operator!=(const WalletItems& other) const {
   return !(*this == other);
 }
 
 }  // namespace wallet
 }  // namespace autofill