Issue 23754019: Use SequencedWorkerPoolOwner in ParallelTestLauncher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23754019: Use SequencedWorkerPoolOwner in ParallelTestLauncher. (Closed)

Created:
7 years, 3 months ago by earthdok

Modified:
7 years, 3 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use SequencedWorkerPoolOwner in ParallelTestLauncher. Ensures that the SWP is destroyed properly. Fixes memory leaks. BUG=290189 R=phajdan.jr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223247

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	base/test/parallel_test_launcher.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	base/test/parallel_test_launcher.cc	View		4 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/23754019/1

7 years, 3 months ago (2013-09-13 18:32:20 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests, chrome_frame_net_tests, chrome_frame_tests, chrome_frame_unittests, content_browsertests, mini_installer_test, ...

7 years, 3 months ago (2013-09-14 04:21:30 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/23754019/1

7 years, 3 months ago (2013-09-14 10:20:44 UTC) #5

Message was sent while issue was closed.

Change committed as 223247

Expand Messages | Collapse Messages