Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
23753008:
Add json output for gclient. (Closed)
|
Created:
7 years, 3 months ago by iannucci Modified:
7 years, 3 months ago CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org Visibility:
Public. |
DescriptionAdd json output for gclient.
This is in order to support 'features' like got_revision for build systems
unwilling to scrape the human-readable output of gclient in order to extract
basic information :)
R=agable@chromium.org, maruel@chromium.org
BUG=265618
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=225046
Patch Set 1 #
Total comments: 11
Patch Set 2 : Address comments #
Total comments: 6
Patch Set 3 : Fix nits #
Messages
Total messages: 11 (0 generated)
https://chromiumcodereview.appspot.com/23753008/diff/1/gclient.py File gclient.py (right): https://chromiumcodereview.appspot.com/23753008/diff/1/gclient.py#newcode1621 gclient.py:1621: slns = doc.setdefault('solutions', {}) How about: doc = { 'solutions': {} } ? https://chromiumcodereview.appspot.com/23753008/diff/1/gclient.py#newcode1623 gclient.py:1623: slns[d.name.replace('\\', '/')] = { Maybe r'\' instead. Also, is this normalized for trailing slash? https://chromiumcodereview.appspot.com/23753008/diff/1/gclient_scm.py File gclient_scm.py (right): https://chromiumcodereview.appspot.com/23753008/diff/1/gclient_scm.py#newcode367 gclient_scm.py:367: return self._Capture(['rev-parse', 'HEAD']) Note that _Capture will throw an exception on non-zero code. Consider adding --verify so git doesn't output HEAD back if it can't decode. I think it doesn't make much difference though since Capture will be throwing an exception either way. https://chromiumcodereview.appspot.com/23753008/diff/1/gclient_scm.py#newcode... gclient_scm.py:1453: return info['Revision'] Would 'last changed rev' be better?
https://codereview.chromium.org/23753008/diff/1/gclient.py File gclient.py (right): https://codereview.chromium.org/23753008/diff/1/gclient.py#newcode1618 gclient.py:1618: ret = client.RunOnDeps('update', args) Keep this line right above "return ret".
https://codereview.chromium.org/23753008/diff/1/gclient.py File gclient.py (right): https://codereview.chromium.org/23753008/diff/1/gclient.py#newcode1618 gclient.py:1618: ret = client.RunOnDeps('update', args) On 2013/09/16 17:02:59, Aaron Gable wrote: > Keep this line right above "return ret". This function has side effects on client :) https://codereview.chromium.org/23753008/diff/1/gclient.py#newcode1621 gclient.py:1621: slns = doc.setdefault('solutions', {}) On 2013/09/15 16:18:10, Isaac wrote: > How about: doc = { 'solutions': {} } ? Still need a second line to get slns :) https://codereview.chromium.org/23753008/diff/1/gclient.py#newcode1623 gclient.py:1623: slns[d.name.replace('\\', '/')] = { On 2013/09/15 16:18:10, Isaac wrote: > Maybe r'\' instead. Still need \\ because \' is an escape (even in raw strings). > > Also, is this normalized for trailing slash? Done https://codereview.chromium.org/23753008/diff/1/gclient_scm.py File gclient_scm.py (right): https://codereview.chromium.org/23753008/diff/1/gclient_scm.py#newcode367 gclient_scm.py:367: return self._Capture(['rev-parse', 'HEAD']) On 2013/09/15 16:18:10, Isaac wrote: > Note that _Capture will throw an exception on non-zero code. > > Consider adding --verify so git doesn't output HEAD back if it can't decode. I > think it doesn't make much difference though since Capture will be throwing an > exception either way. Dones'd https://codereview.chromium.org/23753008/diff/1/gclient_scm.py#newcode1453 gclient_scm.py:1453: return info['Revision'] On 2013/09/15 16:18:10, Isaac wrote: > Would 'last changed rev' be better? Maybe, but currently it uses Revision as far as I can tell.
This LGTM, but it would be good if you could paste windows and *nix output from the new --json-output flag here just as a sanity check. Thanks. https://codereview.chromium.org/23753008/diff/1/gclient.py File gclient.py (right): https://codereview.chromium.org/23753008/diff/1/gclient.py#newcode1618 gclient.py:1618: ret = client.RunOnDeps('update', args) On 2013/09/19 21:20:43, iannucci wrote: > On 2013/09/16 17:02:59, Aaron Gable wrote: > > Keep this line right above "return ret". > > This function has side effects on client :) Aargh.
Windows/git:
{"solutions": {"src/chrome/test/data/perf/canvas_bench/": {"scm": "git",
"revision": "a7b40ea5ae0239517d78845a5fc9b12976bfc732"},
"third_party/python_26/": {"scm": null, "revision": null},
"src/third_party/swig/Lib/": {"scm": "git", "revision":
"549f0b084ad9c40ef42d111303d831eb8d91252e"}, "testing/gtest/": {"scm": null,
"revision": null}, "src/third_party/icu/": {"scm": "git", "revision":
"4f6674fff46d64372efed0c77ada6bb6b15d219d"}, "src/third_party/speex/": {"scm":
"git", "revision": "f448dfcceac99e0a771feaeedf447523b3fd26e1"},
"src/chrome/test/data/perf/frame_rate/content/": {"scm": "git", "revision":
"c10272c88463efeef6bb19c9ec07c42bc8fe22b9"},
"src/third_party/hunspell_dictionaries/": {"scm": "git", "revision":
"bc7edb352e97fa71e387b9a5522f1bbd5b11a5eb"}, "third_party/lss/": {"scm": null,
"revision": null}, "src/third_party/libphonenumber/src/test/":
{"scm": "git", "revision": "e2bb3065e131fa719af112b6aa55177769cd2428"},
"src/media/cdm/ppapi/api/": {"scm": "git", "revision":
"c2b192a02546916d28233cfd8b7717ffcdcc8347"}, "src/third_party/libvpx/": {"scm":
"git", "revision": "3c315c7cf74983e7cc6a5290265081bb64ddfeb3"},
"src/third_party/WebKit/": {"scm": "git", "revision":
"1775450ed064af7a72289649930028fde03f8c25"},
"src/third_party/jsoncpp/source/src/lib_json/": {"scm": "git", "revision":
"a8caa51ba2f80971a45880425bf2ae864a786784"}, "src/third_party/pyftpdlib/src/":
{"scm": "git", "revision": "2be6d65e31c7ee6320d059f581f05ae8d89d7e45"},
"src/third_party/openmax_dl/": {"scm": "git", "revision":
"6b2bf4b577035e2be7e5b096a7148171e5ffadd2"},
"src/chrome_frame/tools/test/reference_build/chrome_win/": {"scm": "git",
"revision": "b9f52667918a74977cb85eefd4e967150f852fbc"},
"src/third_party/scons-2.0.1/": {"scm": "git", "revision":
"c81c95aff36392cffede13382dd5fcad25c0a603"}, "src/tools/swarm_client/": {"scm":
"git", "revision": "e9403abed8fc4720141325057190690e3ca329c6"},
"src/third_party/usrsctp/usrsctplib/": {"scm": "git", "revision":
"ec8cbf0c740353314c289a5bc87a7538e2af08bf"}, "third_party/": {"scm": null,
"revision": null}, "src/third_party/bison/": {"scm": "git", "revision":
"083c9a45e4affdd5464ee2b224c2df649c6e26c3"},
"src/third_party/libjingle/source/talk/": {"scm": "git", "revision":
"3a6035d31f360cb7a9420b7934176494b09721b3"}, "src/third_party/cygwin/": {"scm":
"git", "revision": "3711a17ddd629317f40676bdcc564f32fd7a4fd2"},
"src/third_party/swig/win/": {"scm": "git", "revision":
"986f013ba518541adf5c839811efb35630a31031"}, "src/third_party/libjpeg_turbo/":
{"scm": "git", "revision": "82ce8a6d4ebe12a177c0c3597192f2b4f09e81c3"},
"src/native_client/": {"scm": "git", "revision":
"72351beb9e52a15ee304591a8d6d70af865f8e7c"}, "src/v8/": {"scm": "git",
"revision": "27ce87485ab441498d1e5122df29234e01d0b945"},
"src/third_party/perl/": {"scm": "git", "revision":
"ac0d98b5cee6c024b0cffeb4f8f45b6fc5ccdb78"}, "validator_snapshots/": {"scm":
null,
"revision": null}, "src/third_party/smhasher/src/": {"scm": "git", "revision":
"6f63a4882e6b2cf87e8eec1a3ef8644e0d963283"}, "src/third_party/sfntly/cpp/src/":
{"scm": "git", "revision": "cfb2f1743f0169ad8d01035458617bce97107539"},
"src/third_party/gnu_binutils/": {"scm": "git", "revision":
"f4003433b61b25666565690caf3d7a7a1a4ec436"}, "src/third_party/python_26/":
{"scm": "git", "revision": "67d19f904470effe3122d27101cc5a8195abd157"},
"third_party/gnu_binutils/": {"scm": null, "revision": null},
"src/third_party/nacl_sdk_binaries/": {"scm": "git", "revision":
"759dfca03bdc774da7ecbf974f6e2b84f43699a5"}, "src/testing/gtest/": {"scm":
"git", "revision": "a6772271f71672e889776bfe49ec4efd9da036df"},
"src/chrome/test/data/extensions/api_test/permissions/nacl_enabled/bin/":
{"scm": "git", "revision": "3e17365176c94624f46cace174f61834b7f3c35d"},
"src/third_party/xulrunner-sdk/": {"scm": "git", "revision":
"e9b241c183fa4e7af838ecd70714069ca0eb150c"}, "src/third_party/hunspell/":
{"scm": "git", "revision": "37403978cd939a2b396a5d49944af54623e4795e"},
"src/third_party/yasm/source/patched-yasm/": {"scm": "git", "revision":
"c960eb11ccda80b10ed50be39df4f0663b371d1d"}, "src/tools/gyp/": {"scm": "git",
"revision": "1f8c75bbcc90457341ed1cb8cb10525b7779a4fe"},
"src/third_party/webdriver/pylib/": {"scm": "git", "revision":
"8212c8017c92a1ba740caf01c1acefb3674a6a44"}, "src/third_party/pefile/": {"scm":
"git", "revision": "d0ca75794f69f1d09fd6d31d40ba2f1e9b3b7fb4"},
"src/third_party/trace-viewer/": {"scm": "git", "revision":
"6f9e15ef2051cb550c21d9e09e013ece0e6f8d37"}, "third_party/mingw-w64/mingw/bin/":
{"scm": null, "revision": null}, "native_client/tools/perf_expectations/":
{"scm": null, "revision": null}, "src/testing/gmock/": {"scm": "git",
"revision": "6b1759c3816d574bddde3e1725c51a811c8870e7"},
"src/third_party/libyuv/": {"scm": "git", "revision":
"d36d2606fc7c9d719190676740b4d7b0cc53942f"}, "src/sdch/open-vcdiff/": {"scm":
"git", "revision": "438f2a5be6d809bc21611a94cd37bfc8c28ceb33"},
"src/third_party/libexif/sources/": {"scm": "git", "revision":
"d815c325bab0d1871d4c7e70600ecdfdab07db9e"}, "src/third_party/syzygy/binaries/":
{"scm": "git", "revision": "1c3284dc2d2304641b0d8cfe580b6ac8623773eb"},
"src/third_party/ffmpeg/": {"scm": "git", "revision":
"5879ccd47e649bf2dfaec45f02ec5517bd3621d2"}, "src/third_party/cld_2/src/":
{"scm": "git", "revision": "b17c3c025db379fbeb56c4215bc1eb8737576f4c"},
"src/third_party/accessibility-developer-tools/": {"scm": "git", "revision":
"2e3c9c8e49277a0ca1eeba510271eb03f9486d8f"}, "src/third_party/lighttpd/":
{"scm": "git", "revision": "856e79c6109d4f0abe93c01d4c22419e33c9bee7"},
"src/third_party/opus/src/": {"scm": "git", "revision":
"6b6bee25314cfac02cc555cddedb9680c63a26d6"}, "src/": {"scm": "git", "revision":
"a000af0e74b2c438fdcf3903b2cdda671aa9397a"},
"src/third_party/mingw-w64/mingw/bin/": {"scm": "git", "revision":
"3cc8b140b883a9fe4986d12cfd46c16a093d3527"}, "breakpad/": {"scm": null,
"revision": null}, "src/third_party/jsoncpp/source/include/": {"scm": "git",
"revision": "b0dd48e02b6e6248328db78a65b5c601f150c349"}, "src/third_party/ots/":
{"scm": "git", "revision": "e595ce5916bd91dbc4ddd57fd772af51b1f40c50"},
"src/third_party/libphonenumber/src/phonenumbers/": {"scm": "git", "revision":
"c636308f0ab6fb1af7589eaf0917103dc22fa61e"}, "src/third_party/skia/include/":
{"scm": "git", "revision": "490be8e4386dd93431d4e4e679870fed7eb71d28"},
"src/third_party/angle_dx11/": {"scm":
"git", "revision": "300b1eb5018651d2e68289a9dd234bbf906b3cc0"},
"src/third_party/webgl_conformance/": {"scm": "git", "revision":
"eddddb40ed480aa7aa25e4ff519fea122044ea8e"},
"src/third_party/safe_browsing/testing/": {"scm": "git", "revision":
"9d7e8064f3ca2e45891470c9b5b1dce54af6a9d6"}, "src/third_party/gperf/": {"scm":
"git", "revision": "d892d79f64f9449770443fb06da49b5a1e5d33c1"},
"src/tools/deps2git/": {"scm": "git", "revision":
"92b6fca498aa9d9cca70e80b25a4c41313a537f0"}, "src/third_party/pywebsocket/src/":
{"scm": "git", "revision": "e8de2ba77f55c48e291f70f389f647fafd12ec87"},
"src/third_party/leveldatabase/src/": {"scm": "git", "revision":
"2d749ea62f0e47281e82794c8e00eb588cd66616"}, "src/third_party/yasm/binaries/":
{"scm": "git", "revision": "52f9b3f4b0aa06da24ef8b123058bb61ee468881"},
"src/third_party/psyco_win32/": {"scm": "git", "revision":
"a9e06703f2909e3725cf01e415daaac617fb319e"},
"src/third_party/cacheinvalidation/src/": {"scm": "git", "revision":
"1ea5629c3d190998a24a14ffb58193e109b71855"},
"src/chrome/test/data/perf/third_party/octane/": {"scm": "git", "revision":
"9ac27bfd9e0bc73663db0c0551440215d8b20d09"}, "src/third_party/nss/": {"scm":
"git", "revision": "6c8f5f52d485d7e47c16a533fd6c91657e918320"},
"src/chrome/tools/test/reference_build/chrome_win/": {"scm": "git", "revision":
"e9e680bb8bd498d8a72810d33b55052794c6f5e2"}, "tools/valgrind/": {"scm": null,
"revision": null}, "tools/gyp/": {"scm": null,
"revision": null}, "src/third_party/skia/gyp/": {"scm": "git", "revision":
"f186dad96e7c98490db4850f0fe335ea32f51758"}, "tools/clang/": {"scm": null,
"revision": null}, "src/third_party/webpagereplay/": {"scm": "git", "revision":
"4bb19b79437f638749383e180f44722637c1aa65"}, "src/tools/page_cycler/acid3/":
{"scm": "git", "revision": "6be0a66a1ebd7ebc5abc1b2f405a945f6d871521"},
"src/third_party/flac/": {"scm": "git", "revision":
"71e33f190a7bb144fe4e2014897b8d15c8247198"}, "src/third_party/libsrtp/": {"scm":
"git", "revision": "c3261b9d0df2c7371f4acc28008ec0c891e44faf"},
"src/third_party/bidichecker/": {"scm": "git", "revision":
"97f2aa645b74c28c57eca56992235c79850fa9e0"},
"src/third_party/libphonenumber/src/resources/": {"scm": "git", "revision":
"ba3bf9736e48fc0616bb26b1823feeb58a09de54"}, "src/breakpad/src/": {"scm": "git",
"revision": "f753127663fb164b0b61a147cb93bbca496e1166"},
"src/third_party/mesa/src/": {"scm": "git", "revision":
"2a3406721cd61852bebd502c7a907cf07b7be731"}, "third_party/lcov/": {"scm": null,
"revision": null}, "src/third_party/skia/src/": {"scm": "git", "revision":
"553b8505a7e06e810707c2b8e2d74326b18ec85c"}, "src/third_party/webrtc/": {"scm":
"git", "revision": "496cc4b0a79cf30e5d1d449488327a0f1fbb517d"},
"src/third_party/snappy/src/": {"scm": "git", "revision":
"762bb32f0c9d2f31ba4958c7c0933d22e80c20bf"}, "src/tools/grit/": {"scm": "git",
"revision": "11e589a0b4a958ad1b5411692ee576cbee9f6ca5"}, "third_party/NSIS/":
{"scm": null, "revision": null}}}
Linux/svn:
{"solutions": {"src/chrome/test/data/perf/canvas_bench/": {"scm": "svn",
"revision": 122605}, "trunk/third_party/googlemock/": {"scm": null, "revision":
null}, "src/third_party/libyuv/build/": {"scm": null, "revision": null},
"src/third_party/gold/": {"scm": "svn", "revision": 203758},
"src/third_party/swig/Lib/": {"scm": "svn", "revision": 69281},
"testing/gtest/": {"scm": null, "revision": null}, "src/third_party/icu/":
{"scm": "svn", "revision": 223384}, "src/third_party/speex/": {"scm": "svn",
"revision": 198168}, "src/third_party/pyelftools/": {"scm": "git", "revision":
"bdc1d380acd88d4bfaf47265008091483b0d614e"},
"src/chrome/test/data/perf/frame_rate/content/": {"scm": "svn", "revision":
93671}, "src/third_party/hunspell_dictionaries/": {"scm": "svn", "revision":
193701}, "src/third_party/chromite/": {"scm": "git", "revision":
"cbdd21c5ea76aa93ba4619a6d253697765f4de1f"}, "third_party/lss/": {"scm": null,
"revision": null}, "src/third_party/libphonenumber/src/test/": {"scm": "svn",
"revision": 584}, "src/media/cdm/ppapi/api/": {"scm": "svn", "revision":
181763}, "src/third_party/libvpx/": {"scm": "svn", "revision": 224839},
"v8/build/gyp/": {"scm": null, "revision": null},
"src/third_party/libyuv/third_party/yasm/source/patched-yasm/": {"scm": null,
"revision": null}, "trunk/third_party/googletest/": {"scm": null, "revision":
null}, "src/third_party/chromium_deps/": {"scm": null, "revision": null},
"src/third_party/libyuv/tools/python/": {"scm": null, "revision": null},
"src/third_party/jsoncpp/source/src/lib_json/": {"scm": "svn", "revision": 248},
"src/third_party/pyftpdlib/src/": {"scm": "svn", "revision": 977},
"src/third_party/openmax_dl/": {"scm": "svn", "revision": 4261},
"src/chrome_frame/tools/test/reference_build/chrome_win/": {"scm": null,
"revision": null}, "src/third_party/scons-2.0.1/": {"scm": "svn", "revision":
11437}, "src/tools/swarm_client/": {"scm": "svn", "revision": 224429},
"src/third_party/usrsctp/usrsctplib/": {"scm": "svn", "revision": 8603},
"src/third_party/libyuv/third_party/gold/": {"scm": null, "revision": null},
"third_party/": {"scm": null, "revision": null},
"src/third_party/libyuv/testing/gtest/": {"scm": null, "revision": null},
"src/third_party/libjingle/source/talk/": {"scm": "svn", "revision": 4819},
"src/third_party/lss/": {"scm": "svn", "revision": 24},
"src/third_party/libyuv/tools/valgrind/": {"scm": null, "revision": null},
"src/third_party/libjpeg_turbo/": {"scm": "svn", "revision": 177737},
"src/native_client/": {"scm": "svn", "revision": 12181}, "src/v8/": {"scm":
"svn", "revision": 16822}, "v8/third_party/icu/": {"scm": null, "revision":
null}, "src/chrome/tools/test/reference_build/chrome_linux/": {"scm": null,
"revision": null}, "src/third_party/smhasher/src/": {"scm": "svn", "revision":
149}, "src/third_party/sfntly/cpp/src/": {"scm": "svn", "revision": 134},
"src/chrome/tools/test/reference_build/chrome_mac/": {"scm": null, "revision":
null}, "src/chrome/tools/test/reference_build/chrome/": {"scm": null,
"revision": null}, "src/testing/gtest/": {"scm": "svn", "revision": 629},
"src/third_party/libyuv/tools/gyp/": {"scm": null, "revision": null},
"src/chrome/test/data/extensions/api_test/permissions/nacl_enabled/bin/":
{"scm": "svn", "revision": 12181}, "src/third_party/hunspell/": {"scm": "svn",
"revision": 206172}, "src/third_party/yasm/source/patched-yasm/": {"scm": "svn",
"revision": 167605}, "src/tools/gyp/": {"scm": "svn", "revision": 1735},
"src/third_party/webdriver/pylib/": {"scm": "svn", "revision": 18337},
"src/third_party/mtpd/source/": {"scm": "git", "revision":
"5be739c938a0a229ba9479b00b180e1f9c843e81"},
"src/third_party/libyuv/tools/clang/": {"scm": null, "revision": null},
"src/third_party/trace-viewer/": {"scm": "svn", "revision": 1006},
"src/third_party/libmtp/": {"scm": "svn", "revision": 206535},
"trunk/third_party/gyp/": {"scm": null, "revision": null}, "src/testing/gmock/":
{"scm": "svn", "revision": 410}, "src/third_party/libyuv/": {"scm": "svn",
"revision": 723}, "src/third_party/libyuv/testing/": {"scm": null, "revision":
null}, "src/sdch/open-vcdiff/": {"scm": "svn", "revision": 42},
"src/third_party/freetype2/src/": {"scm": "git", "revision":
"d699c2994ecc178c4ed05ac2086061b2034c2178"},
"src/third_party/libyuv/google_apis/build/": {"scm": null, "revision": null},
"src/third_party/libexif/sources/": {"scm": "svn", "revision": 146817},
"src/third_party/ffmpeg/": {"scm": "svn", "revision": 224426},
"src/third_party/xdg-utils/": {"scm": "svn", "revision": 203785},
"src/third_party/libyuv/third_party/libjpeg_turbo/": {"scm": null, "revision":
null}, "src/third_party/accessibility-developer-tools/": {"scm": "git",
"revision": "2e3c9c8e49277a0ca1eeba510271eb03f9486d8f"},
"src/third_party/WebKit/": {"scm": "svn", "revision": 158259},
"src/third_party/cros_system_api/": {"scm": "git", "revision":
"205bfa55bbf3287769a600d7fa29e000d0ff085e"}, "src/third_party/opus/src/":
{"scm": "svn", "revision": 185324}, "src/": {"scm": "svn", "revision": 225028},
"src/third_party/swig/linux/": {"scm": "svn", "revision": 69281}, "breakpad/":
{"scm": null, "revision": null}, "native_client/tools/perf_expectations/":
{"scm": null, "revision": null}, "src/third_party/jsoncpp/source/include/":
{"scm": "svn", "revision": 248}, "src/third_party/ots/": {"scm": "svn",
"revision": 102}, "src/third_party/libphonenumber/src/phonenumbers/": {"scm":
"svn", "revision": 584}, "third_party/ragel/": {"scm": null, "revision": null},
"src/third_party/skia/include/": {"scm": "svn", "revision": 11429},
"src/third_party/angle_dx11/": {"scm": "git", "revision":
"300b1eb5018651d2e68289a9dd234bbf906b3cc0"},
"src/third_party/webgl_conformance/": {"scm": "svn", "revision": 218717},
"src/third_party/safe_browsing/testing/": {"scm": "svn", "revision": 112},
"src/tools/deps2git/": {"scm": "svn", "revision": 214390},
"src/third_party/pywebsocket/src/": {"scm": "svn", "revision": 662},
"src/third_party/leveldatabase/src/": {"scm": "svn", "revision": 77},
"src/third_party/undoview/": {"scm": "svn", "revision": 119694},
"src/third_party/cacheinvalidation/src/": {"scm": "svn", "revision": 313},
"src/chrome/test/data/perf/third_party/octane/": {"scm": "svn", "revision": 19},
"src/chrome/tools/test/reference_build/chrome_win/": {"scm": null, "revision":
null}, "tools/valgrind/": {"scm": null, "revision": null}, "tools/gyp/": {"scm":
null, "revision": null}, "src/third_party/skia/gyp/": {"scm": "svn", "revision":
11429}, "tools/clang/": {"scm": null, "revision": null},
"src/third_party/webpagereplay/": {"scm": "svn", "revision": 521},
"validator_snapshots/": {"scm": null, "revision": null},
"src/tools/page_cycler/acid3/": {"scm": "svn", "revision": 171600},
"src/third_party/flac/": {"scm": "svn", "revision": 222897},
"src/third_party/libsrtp/": {"scm": "svn", "revision": 214783},
"src/third_party/bidichecker/": {"scm": "svn", "revision": 4},
"src/third_party/libphonenumber/src/resources/": {"scm": "svn", "revision":
584}, "src/breakpad/src/": {"scm": "svn", "revision": 1213},
"src/chrome_frame/tools/test/reference_build/chrome/": {"scm": null, "revision":
null}, "src/third_party/mesa/src/": {"scm": "svn", "revision": 210110},
"src/third_party/libyuv/tools/win/supalink/": {"scm": null, "revision": null},
"third_party/lcov/": {"scm": null, "revision": null},
"src/third_party/skia/src/": {"scm": "svn", "revision": 11429},
"src/third_party/webrtc/": {"scm": "svn", "revision": 4819},
"src/third_party/cld_2/src/": {"scm": "svn", "revision": 84},
"src/third_party/snappy/src/": {"scm": "svn", "revision": 80},
"src/third_party/cros_dbus_cplusplus/source/": {"scm": "git", "revision":
"5e8f6d9db5c2abfb91d91f751184f25bb5cd0900"}, "src/tools/grit/": {"scm": "svn",
"revision": 136}, "src/third_party/openssl/": {"scm": "svn", "revision":
207965}, "src/third_party/libyuv/third_party/yasm/": {"scm": null, "revision":
null}}}
lgtm with nits https://codereview.chromium.org/23753008/diff/8001/gclient.py File gclient.py (right): https://codereview.chromium.org/23753008/diff/8001/gclient.py#newcode1620 gclient.py:1620: doc = {} slns = {} https://codereview.chromium.org/23753008/diff/8001/gclient.py#newcode1623 gclient.py:1623: normed = d.name.replace('\\', '/') normed = d.name.replace('\\', '/').rstrip('/') + '/' https://codereview.chromium.org/23753008/diff/8001/gclient.py#newcode1631 gclient.py:1631: json.dump(doc, f) json.dump({'solutions': slns}, f)
thanks! https://codereview.chromium.org/23753008/diff/8001/gclient.py File gclient.py (right): https://codereview.chromium.org/23753008/diff/8001/gclient.py#newcode1620 gclient.py:1620: doc = {} On 2013/09/24 18:52:41, M-A Ruel wrote: > slns = {} Done. https://codereview.chromium.org/23753008/diff/8001/gclient.py#newcode1623 gclient.py:1623: normed = d.name.replace('\\', '/') On 2013/09/24 18:52:41, M-A Ruel wrote: > normed = d.name.replace('\\', '/').rstrip('/') + '/' Done. https://codereview.chromium.org/23753008/diff/8001/gclient.py#newcode1631 gclient.py:1631: json.dump(doc, f) On 2013/09/24 18:52:41, M-A Ruel wrote: > json.dump({'solutions': slns}, f) Done.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/23753008/17001
Message was sent while issue was closed.
Change committed as 225046 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
