Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23753007: Show file path rather than title in syncfs-internals (Closed)

Created:
7 years, 3 months ago by kinuko
Modified:
7 years, 3 months ago
Reviewers:
tzik
CC:
chromium-reviews, nhiroki+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch, arv+watch_chromium.org
Visibility:
Public.

Description

Show file path rather than title in syncfs-internals BUG=none TEST=manual (open chrome://syncfs-internals, go to File Metadata tab and click 'refresh') Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222251

Patch Set 1 #

Total comments: 2

Messages

Total messages: 7 (0 generated)
tzik
https://codereview.chromium.org/23753007/diff/1/chrome/browser/resources/sync_file_system_internals/main.html File chrome/browser/resources/sync_file_system_internals/main.html (right): https://codereview.chromium.org/23753007/diff/1/chrome/browser/resources/sync_file_system_internals/main.html#newcode20 chrome/browser/resources/sync_file_system_internals/main.html:20: <script src="chrome://syncfs-internals/utils.js"></script> If you put this by relative path, ...
7 years, 3 months ago (2013-09-10 07:50:31 UTC) #1
tzik
lgtm https://codereview.chromium.org/23753007/diff/1/chrome/browser/resources/sync_file_system_internals/main.html File chrome/browser/resources/sync_file_system_internals/main.html (right): https://codereview.chromium.org/23753007/diff/1/chrome/browser/resources/sync_file_system_internals/main.html#newcode20 chrome/browser/resources/sync_file_system_internals/main.html:20: <script src="chrome://syncfs-internals/utils.js"></script> On 2013/09/10 07:50:31, tzik wrote: > ...
7 years, 3 months ago (2013-09-10 08:22:33 UTC) #2
kinuko
On 2013/09/10 08:22:33, tzik wrote: > lgtm > > https://codereview.chromium.org/23753007/diff/1/chrome/browser/resources/sync_file_system_internals/main.html > File chrome/browser/resources/sync_file_system_internals/main.html (right): > ...
7 years, 3 months ago (2013-09-10 08:27:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/23753007/1
7 years, 3 months ago (2013-09-10 08:28:51 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=167320
7 years, 3 months ago (2013-09-10 09:35:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/23753007/1
7 years, 3 months ago (2013-09-10 09:36:25 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 11:38:21 UTC) #7
Message was sent while issue was closed. 
Change committed as 222251

Powered by Google App Engine
This is Rietveld 408576698