Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Issue 23753006: base: Rename OSLockType to NativeHandle in Lock API. (Closed)

Created:
7 years, 3 months ago by tfarina
Modified:
7 years, 3 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

base: Rename OSLockType to NativeHandle in Lock API. This inline us more with the standard http://en.cppreference.com/w/cpp/thread/mutex. BUG=283054 TEST=base_unittests R=brettw@chromium.org, darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223227

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M base/synchronization/condition_variable_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/synchronization/condition_variable_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/synchronization/lock_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M base/synchronization/lock_impl_posix.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M base/synchronization/lock_impl_win.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
7 years, 3 months ago (2013-09-10 02:28:24 UTC) #1
tfarina
-thakis +Darin!
7 years, 3 months ago (2013-09-13 22:52:15 UTC) #2
darin (slow to review)
LGTM
7 years, 3 months ago (2013-09-13 22:55:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/23753006/1
7 years, 3 months ago (2013-09-13 23:03:38 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-14 05:27:09 UTC) #5
Message was sent while issue was closed.
Change committed as 223227

Powered by Google App Engine
This is Rietveld 408576698