Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: content/renderer/media/webrtc_local_audio_track.cc

Issue 23752002: Always set need_audio_processing_ to true in WebRtcLocalAudioTrack. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Update tests Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/media/webrtc_local_audio_track_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/webrtc_local_audio_track.cc
diff --git a/content/renderer/media/webrtc_local_audio_track.cc b/content/renderer/media/webrtc_local_audio_track.cc
index cae6bfe8ba38bcd85a32f75cf6c6faaa6d1514e5..ecdfc8ec7e3b556045690a51b59e5d61b69ba69c 100644
--- a/content/renderer/media/webrtc_local_audio_track.cc
+++ b/content/renderer/media/webrtc_local_audio_track.cc
@@ -34,6 +34,12 @@ WebRtcLocalAudioTrack::WebRtcLocalAudioTrack(
// and APM (AudioProcessingModule) is turned on only for microphone data.
DCHECK(capturer.get());
DVLOG(1) << "WebRtcLocalAudioTrack::WebRtcLocalAudioTrack()";
+
+ // TODO(tommi): Remove this, feed audio constraints to WebRtcLocalAudioTrack
+ // and check the constraints. This is here to fix a recent regression whereby
+ // audio processing is not enabled for WebAudio regardless of the hard coded
+ // audio constraints. For more info: http://crbug.com/277134
+ need_audio_processing_ = true;
}
WebRtcLocalAudioTrack::~WebRtcLocalAudioTrack() {
« no previous file with comments | « no previous file | content/renderer/media/webrtc_local_audio_track_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698