Issue 23752002: Always set need_audio_processing_ to true in WebRtcLocalAudioTrack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23752002: Always set need_audio_processing_ to true in WebRtcLocalAudioTrack. (Closed)

Created:
7 years, 3 months ago by tommi (sloooow) - chröme

Modified:
7 years, 3 months ago

Reviewers:
no longer working on chromium

CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Always set need_audio_processing_ to true in WebRtcLocalAudioTrack. This is a simple fix for a regression that's affecting PeerConnection based apps that also use WebAudio. A longer term fix is also ready but I'd like to land this shorter term fix so that merging to release branches will be easy and low risk. (the other CL is here: https://codereview.chromium.org/23171026/) BUG=277134 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220570

Patch Set 1 #

Patch Set 2 : Update tests #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -34 lines)			Patch
	M	content/renderer/media/webrtc_local_audio_track.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	content/renderer/media/webrtc_local_audio_track_unittest.cc	View	1	5 chunks	+44 lines, -34 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

no longer working on chromium

On 2013/08/29 08:44:24, tommi wrote: obviously you need to update the test as well :( ...

7 years, 3 months ago (2013-08-29 09:08:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/23752002/22001

7 years, 3 months ago (2013-08-30 07:56:01 UTC) #4

Message was sent while issue was closed.

Change committed as 220570

Expand Messages | Collapse Messages