Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 23751002: Add InputMethod::GetTextInputMode (Closed)

Created:
7 years, 3 months ago by yoichio
Modified:
7 years, 3 months ago
CC:
chromium-reviews, nona+watch_chromium.org, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Add InputMethod::GetTextInputMode It retuns clients' input mode if clients is focused. BUG=244688 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220318

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -5 lines) Patch
M ui/base/ime/dummy_input_method.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ime/dummy_input_method.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/base/ime/fake_input_method.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/ime/fake_input_method.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download
M ui/base/ime/input_method.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M ui/base/ime/input_method_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ime/input_method_base.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/base/ime/mock_input_method.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ime/mock_input_method.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yoichio
GetTextInputType() returns TextInputClient's GetTextInputType(). It's confusing so how about to rename it to InputMethod::GetClientTextInputType/InputMode/CanComposeInline?
7 years, 3 months ago (2013-08-29 08:23:03 UTC) #1
Seigo Nonaka
lgtm Make sense. Please file an issue and leave TODO comment into GetTextInputClient.
7 years, 3 months ago (2013-08-29 09:01:18 UTC) #2
Yohei Yukawa
lgtm with a nit. https://codereview.chromium.org/23751002/diff/1/ui/base/ime/fake_input_method.h File ui/base/ime/fake_input_method.h (right): https://codereview.chromium.org/23751002/diff/1/ui/base/ime/fake_input_method.h#newcode47 ui/base/ime/fake_input_method.h:47: virtual ui::TextInputType GetTextInputType() const OVERRIDE; ...
7 years, 3 months ago (2013-08-29 09:13:02 UTC) #3
yoichio
Thanks. https://codereview.chromium.org/23751002/diff/1/ui/base/ime/fake_input_method.h File ui/base/ime/fake_input_method.h (right): https://codereview.chromium.org/23751002/diff/1/ui/base/ime/fake_input_method.h#newcode47 ui/base/ime/fake_input_method.h:47: virtual ui::TextInputType GetTextInputType() const OVERRIDE; On 2013/08/29 09:13:02, ...
7 years, 3 months ago (2013-08-29 09:30:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/23751002/12001
7 years, 3 months ago (2013-08-29 09:30:27 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-08-29 16:36:43 UTC) #6
Message was sent while issue was closed.
Change committed as 220318

Powered by Google App Engine
This is Rietveld 408576698