Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 23750002: Defer enabling native accessibility until it's used. (Closed)

Created:
7 years, 3 months ago by dmazzoni
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Defer enabling native accessibility until it's used. We were enabling native accessibility if any accessibility service was running, but many Android users have accessibility services other than screen readers. Now we only enable native accessibility if getAccessibilityNodeProvider is called on the web content. Many popular Android apps that happen to be accessibility services will no longer trigger Chrome's accessibility mode. BUG=280717 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220541

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix wrap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -21 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 3 chunks +26 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dmazzoni
7 years, 3 months ago (2013-08-29 05:50:27 UTC) #1
dmazzoni
See the bug for more context, and a description of exactly how I tested it.
7 years, 3 months ago (2013-08-29 16:41:28 UTC) #2
David Trainor- moved to gerrit
lgtm https://codereview.chromium.org/23750002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/23750002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode2787 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:2787: mNativeContentViewCore != 0 && Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN) { ...
7 years, 3 months ago (2013-08-29 18:22:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/23750002/9001
7 years, 3 months ago (2013-08-29 19:31:05 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=23076
7 years, 3 months ago (2013-08-29 19:43:32 UTC) #5
dmazzoni
+joth or tedchoc for OWNERS review
7 years, 3 months ago (2013-08-29 22:01:45 UTC) #6
joth
lgtm
7 years, 3 months ago (2013-08-30 03:57:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/23750002/9001
7 years, 3 months ago (2013-08-30 05:26:34 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 09:05:11 UTC) #9
Message was sent while issue was closed.
Change committed as 220541

Powered by Google App Engine
This is Rietveld 408576698